Simple foreach loop in MVC

Question

   <% foreach (var car in Model.AvailableCars)
  { %>
       <label><%car.Text; %></label>

   <% } %>

The above code throws the error

Only assignment, call, increment, decrement, and new object expressions can be used as a statement.

I know I can do it with html helpers, but why won't the above code work?

Robert Harvey · Accepted Answer · 2013-04-15 22:37:29Z

3

<label><%car.Text; %></label>

should read

<label><%= car.Text; %></label>  
         ^

or you can use

<label><%: car.Text; %></label>
         ^

which will automatically HTML.Encode the value for you.

answered Apr 15, 2013 at 22:37

Robert Harvey

182k48 gold badges349 silver badges516 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Foo Over a year ago

That worked:). I will accept this as the answer as soon as it lets me (in 9 mins)

Nick Albrecht Over a year ago

Unless you have an explicit reason to NOT HtmlEncode the value being displayed I'd recommend always using <%:car.Text%> to write your text to the page. Or in the case of Razor, @car.Text which HtmlEncodes all text by default. You'd have to explicitly use @Html.Raw(car.Text) to not HtmlEncode it with Razor.

Community · Accepted Answer · 2017-05-23 11:43:18Z

1

Add a colon to the car.Text tag to write it to the document, such as:

<label><%: car.Text %></label>

Here's a good explanation of <%: versus <%= asp.net mvc tags: <%: %> vs. <%= %>

edited May 23, 2017 at 11:43

CommunityBot

11 silver badge

answered Apr 15, 2013 at 22:36

Stephen Fischer

2,5562 gold badges23 silver badges38 bronze badges

Collectives™ on Stack Overflow

Simple foreach loop in MVC

2 Answers 2

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Linked

Related