How do I compare two variables containing strings in JavaScript?

Question

I want compare two variables, that are strings, but I am getting an error.

<script>
    var to_check=$(this).val();
    var cur_string=$("#0").text();
    var to_chk = "that";
    var cur_str= "that";

    if(to_chk==cur_str){
        alert("both are equal");
        $("#0").attr("class","correct");    
    } else {
        alert("both are not equal");
        $("#0").attr("class","incorrect");
    }
</script>

Is something wrong with my if statement?

This should do the trick, its not where your problem is. Show the code. — Havenard
– Havenard, Commented Apr 1, 2013 at 5:16
please post more code with how you get to_chk and cur_str ... can't tell from that — Youn Elan
– Youn Elan, Commented Apr 1, 2013 at 5:16
try to delete any whitespace from begining and end of string and convert to lower case — chepe263
– chepe263, Commented Apr 1, 2013 at 6:53

Anders Lindén · Accepted Answer · 2017-05-31 05:05:49Z

20

=== is not necessary. You know both values are strings so you dont need to compare types.

function do_check()
{
  var str1 = $("#textbox1").val();
  var str2 = $("#textbox2").val();

  if (str1 == str2)
  {
    $(":text").removeClass("incorrect");
    alert("equal");
  }
  else
  {
    $(":text").addClass("incorrect");
    alert("not equal");
  }
}

.incorrect
{
  background: #ff8888;
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

<input id="textbox1" type="text">
<input id="textbox2" type="text">

<button onclick="do_check()">check</button>

edited May 31, 2017 at 5:05

answered Apr 1, 2013 at 9:56

Anders Lindén

7,43413 gold badges61 silver badges122 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sannu Over a year ago

I had same issue today and comparison would not work. After spending couple of hours pulling my hair, i figured i was initializing my variable as var x; and comparison did not work. When I changed var x=""; it worked. So I am guessing, it was using object comparison as oppose to string comparison.

anztrax · Accepted Answer · 2013-04-01 09:40:54Z

6

instead of using the == sign, more safer use the === sign when compare, the code that you post is work well

answered Apr 1, 2013 at 9:40

anztrax

7957 silver badges9 bronze badges

2 Comments

Anders Lindén Over a year ago

No, both values in the comparision will be strings.

The Bumpaster Over a year ago

how do you achieve this? if(a b) a = 12345 , b = 123 to be true, because a has all of b elements?

Kiran Chenna · Accepted Answer · 2019-03-03 18:11:31Z

You can use javascript dedicate string compare method string1.localeCompare(string2). it will five you -1 if the string not equals, 0 for strings equal and 1 if string1 is sorted after string2.

<script>
    var to_check=$(this).val();
    var cur_string=$("#0").text();
    var to_chk = "that";
    var cur_str= "that";
    if(to_chk.localeCompare(cur_str) == 0){
        alert("both are equal");
        $("#0").attr("class","correct");    
    } else {
        alert("both are not equal");
        $("#0").attr("class","incorrect");
    }
</script>

Shaik MD Younus · Accepted Answer · 2022-12-21 10:50:16Z

2

Try this , it works.

<script>
var to_check=$(this).val();
var cur_string=$("#0").text();
var to_chk = "that";
var cur_str= "that";
if(to_chk.localeCompare(cur_str) === 0){
    alert("both are equal");
    $("#0").attr("class","correct");    
} else {
    alert("both are not equal");
    $("#0").attr("class","incorrect");
}

answered Dec 21, 2022 at 10:50

Shaik MD Younus

594 bronze badges

1 Comment

ahuemmer Over a year ago

Copied 1:1 from Kiran Chenna's answer.

slfan · Accepted Answer · 2017-10-03 06:00:00Z

1

I used below function to compare two strings and It is working good.

function CompareUserId (first, second)
{

   var regex = new RegExp('^' + first+ '$', 'i');
   if (regex.test(second)) 
   {
        return true;
   }
   else 
   {
        return false;
   }
   return false;
}

edited Oct 3, 2017 at 6:00

slfan

9,129115 gold badges69 silver badges81 bronze badges

answered Oct 3, 2017 at 5:39

Sivakumar Jallu

112 bronze badges

Collectives™ on Stack Overflow

How do I compare two variables containing strings in JavaScript?

5 Answers 5

1 Comment

2 Comments

Comments

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

Comments

1 Comment

Comments

Linked

Related