vb6 function not returning a value

Question

VB noob here, working on a legacy VB 6.0 application.

When I check the value of lineno within the function below, I am getting the expected value:

Public Function GetNumOfLines(filename As String) As Integer
    Dim lineno as Integer
    lineno = 0  
    Open App.Path + filename For Input As #1

    Do While Not EOF(1)
        lineno = lineno + 1
        Line Input #1, linevar
        Loop
        Close #1

    MsgBox "numOfLines: " & lineno 'This works
    End Function

But when I call GetNumOfLines from GetATRNames (below), numOfLines is 0:

Public Function GetATRNames() As String()   
    Dim filename as String  
    filename = "\atrname.dat"
    Dim numOfLines as Integer
    numOfLines = GetNumOfLines(filename)

    MsgBox "numOfLines: " & numOfLines 'This does not
        End Function

Any ideas on why numOfLines = GetNumOfLines(filename) is giving me a different value than when I check within GetNumOfLines?

user1945782 · Accepted Answer · 2013-03-19 16:55:48Z

6

You're not returning the value. Put:

GetNumOfLines = lineno

At the end of the first function.

answered Mar 19, 2013 at 16:55

user1945782

Sign up to request clarification or add additional context in comments.

Comments

tcarvin · Accepted Answer · 2013-03-19 16:56:11Z

3

You just need to return your value:

Public Function GetNumOfLines(filename As String) As Integer
    Dim lineno as Integer
    lineno = 0  
    Open App.Path + filename For Input As #1

    Do While Not EOF(1)
        lineno = lineno + 1
        Line Input #1, linevar
        Loop
        Close #1

    MsgBox "numOfLines: " & lineno 'This works

    'return number of lines
    GetNumOfLines = lineno

    End Function

answered Mar 19, 2013 at 16:56

tcarvin

10.9k3 gold badges33 silver badges53 bronze badges

Comments

JSR · Accepted Answer · 2013-03-19 16:57:10Z

3

You need to return the value from your GetNumOfLines function

Add the line

GetNumOfLines = lineno

as the last line of your function.

answered Mar 19, 2013 at 16:57

JSR

6,4162 gold badges22 silver badges24 bronze badges

Collectives™ on Stack Overflow

vb6 function not returning a value

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related