Split string into custom List<T>

Question

I need to split a custom string into the following format using C#.

The following string: AD=Demo,OU=WEB,OU=IT,L=MyCity,C=MyCountry, i want to split it at comma into a

List<CustomDictionary> myList = new List<CustomDictionary>();

Based on the text above and after the split, the myList list should contain 5 objects of type CustomDictionary.

 object1.Key = AD
 object1.Value = Demo

 object2.Key = OU
 object2.Value = WEB

 object3.Key = OU
 object3.Value = IT

 object4.Key = L
 object4.Value = MyCity

 object5.Key = C
 object5.Value = MyCountry

Here is the CustomObject class

 public class CustomDictionary
 {
     public string Key { get; set; }
     public string Value { get; set; }

     public CustomDictionary(string key, string value)
     {
         this.Key = key;
         this.Value = value;
     }
 }

So far I tried this:

Here I am stuck!

  List<CustomDictionary> keyVal = new List<CustomDictionary>val.Split(',').Select(x=>x.Split('=')).Select(x=>x.));

where val is the actual string ...

Any reason you can't us the built in Active Directory classes? — Oded
– Oded, Commented Jan 12, 2013 at 17:47
Also, what have you tried? Please post your current code and explain where you are stuck. — Oded
– Oded, Commented Jan 12, 2013 at 17:48
@Oded the string is just a value I receive in the service call ... — David Dury
– David Dury, Commented Jan 12, 2013 at 17:53
I could have split this to a keyvalue pair (Dictionary), but I will have duplicate Key than, unless I will reverse the values but even than I am not sure I will ever receive non-duplicate values so I have to figure this out in some other way ... — David Dury
– David Dury, Commented Jan 12, 2013 at 17:55
So, what's wrong with a List<KeyValuePair>? It is not a dictionary. — Oded
– Oded, Commented Jan 12, 2013 at 17:59

tukaef · Accepted Answer · 2013-01-12 18:07:46Z

5

With linq:

var query = from x in str.Split(',')
            let p = x.Split('=')
            select new CustomDictionary(p[0], p[1]);

var list = query.ToList();

Also seems like you want to get a dictionary as a result. If so, try this code:

var dict = str.Split(',').Select(x => x.Split('='))
                         .ToDictionary(x => x[0], x => x[1]);

To handle duplicate keys, you can store objects in Lookup. Just call ToLookup instead of ToDictionaty.

edited Jan 12, 2013 at 18:07

answered Jan 12, 2013 at 17:53

tukaef

9,2544 gold badges32 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

David Dury Over a year ago

I made it at first with Dictionary but when I run the code, i got an exception because I have duplicate keys: OU ... so this was a lost. however it works fine with the first linq query you shown ...

Guffa · Accepted Answer · 2013-01-12 18:01:09Z

After splitting the second time you create a CustomDictionary from the items in that array, then use ToList to make a list of the result.

List<CustomDictionary> keyVal =
  val.Split(',')
  .Select(x => x.Split('='))
  .Select(a => new CustomDictionary(a[0], a[1]))
  .ToList();

There is already a class in the framework having a key and value, which you can use instead:

List<KeyValuePair<string, string>> keyVal =
  val.Split(',')
  .Select(x => x.Split('='))
  .Select(a => new KeyValuePair<string, string>(a[0], a[1]))
  .ToList();

You can also use a Dictionary<string, string> instead of a list of key-value pairs. It stores the value based on the hash code of the key, so getting a value by key is much faster than looking through a list (but it doesn't retain the order of the items):

Dictionary<string, string> keyVal =
  val.Split(',')
  .Select(x => x.Split('='))
  .ToDictionary(a => a[0], a => a[1]);

Oded · Accepted Answer · 2013-01-12 17:50:29Z

1

This is how you would do it:

var parts = theString.Split(',');

var myList = new List<CustomDictionary>();
foreach(string part in parts)
{
  var kvp = part.Split('=');
  myList.Add(new CustomDictionary(kvp[0], kvp[1]));
}

This can also be done using LINQ.

answered Jan 12, 2013 at 17:50

Oded

501k102 gold badges899 silver badges1k bronze badges

Comments

I4V · Accepted Answer · 2013-01-12 18:03:09Z

1

Since you have 2 OUs you can't use Dictionary. Instead use Lookup

string input = "AD=Demo,OU=WEB,OU=IT,L=MyCity,C=MyCountry";

var dict = Regex.Matches(input, @"(\w+)=([^,$]+)").Cast<Match>()
            .ToLookup(m => m.Groups[1].Value, m => m.Groups[2].Value);

answered Jan 12, 2013 at 18:03

I4V

35.4k6 gold badges71 silver badges82 bronze badges

Comments

elyashiv · Accepted Answer · 2013-01-12 17:52:41Z

0

what about MyString.split(','); and the on each string you get:

CO.key = SubString.split('=')[0];
CO.value = SubString.split('=')[1];

answered Jan 12, 2013 at 17:52

elyashiv

3,7112 gold badges31 silver badges54 bronze badges

Comments

kmatyaszek · Accepted Answer · 2013-01-12 17:56:50Z

0

With LINQ:

List<CustomDictionary> myList = (from x in input.Split(new char[] { ',' })
                                 select
                                 new CustomDictionary (x.Substring(0, x.IndexOf('=')), x.Substring(x.IndexOf('=') + 1))
                                ).ToList();

answered Jan 12, 2013 at 17:56

kmatyaszek

19.3k9 gold badges62 silver badges66 bronze badges

Comments

Luc · Accepted Answer · 2013-01-12 18:08:58Z

0

string str = "AD=Demo,OU=WEB,OU=IT,L=MyCity,C=MyCountry";

var result = str.Split(',').Select(s =>
{
    var tmp = s.Split('=');
    return new CustomDictionary(tmp[0], tmp[1]);
}).ToList();

answered Jan 12, 2013 at 18:08

Luc

1,5281 gold badge13 silver badges31 bronze badges

Collectives™ on Stack Overflow

Split string into custom List<T>

7 Answers 7

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

Related