Android String comparison, substring

Question

My Android app crashes during if statement and I can not find the mistake.

Here is a snippet of my code, how could I fix it?

    public String formatResult(String inVal) {

         String tmp = inVal.substring(inVal.length() - 2, inVal.length());

         if (tmp.equals(".0") == true){

             return inVal.substring(inVal.length(),inVal.length()-2);
         } else {

             return inVal;
         }
    }

You don't need the == true, .equals already does that for you. — Jeroen Vannevel
– Jeroen Vannevel, Commented Dec 30, 2012 at 20:36
To figure out crashes, always start with showing us the logs for the crash — keno
– keno, Commented Dec 30, 2012 at 20:37
return inVal.substring(inVal.length(),inVal.length()-2); You're going backwards in this line. Your 2nd arg is smaller than the first? — CocoNess
– CocoNess, Commented Dec 30, 2012 at 20:41
Sorry, I#m really new to IntelliJ and Java/Android. The whole app crashes. — fillibuster
– fillibuster, Commented Dec 30, 2012 at 20:43

İsmet Alkan · Accepted Answer · 2012-12-30 20:47:38Z

1

"inVal" can be shorter than 2 characters. Debug the project and watch inVal, in any case put if-statements to control if inVal is longer than 2.

You can change:

if (tmp.equals(".0") == true)

to:

if (tmp.equals(".0")){

Another thing is, do you really want to return:

inVal.substring(inVal.length(),inVal.length()-2);

or you want to return:

inVal.substring(inVal.length()-2, inVal.length());

EndIndex cannot be smaller than StartIndex. If you want to start from end to end-2:

string a;
for(int i = inVal.length; i>=inVal.length-2; i--) {
    a += inVal.charAt(i);
}

This should work.

edited Dec 30, 2012 at 20:47

answered Dec 30, 2012 at 20:42

İsmet Alkan

5,4474 gold badges43 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

fillibuster Over a year ago

Hi, I want return inVal.substring(0,inVal.length()-2);. Thanks

Nicklas Gnejs Eriksson · Accepted Answer · 2012-12-30 20:40:00Z

1

inVal.substring(inVal.length(),inVal.length()-2);

not very valid since:

public String substring(int beginIndex,
                        int endIndex)

IndexOutOfBoundsException - if the beginIndex is negative, or endIndex is larger than the length of this String object, or beginIndex is larger than endIndex.

answered Dec 30, 2012 at 20:40

Nicklas Gnejs Eriksson

3,4152 gold badges23 silver badges19 bronze badges

Comments

Cat · Accepted Answer · 2012-12-30 22:12:00Z

0

String a = editboxa.getText().toString();
String b = editboxb.getText().toString();
if(a.equals(b))
    //do something
else
    //do something

edited Dec 30, 2012 at 22:12

Cat

67.6k24 gold badges136 silver badges144 bronze badges

answered Dec 30, 2012 at 20:44

Gridtestmail

1,4899 silver badges10 bronze badges

Collectives™ on Stack Overflow

Android String comparison, substring

3 Answers 3

1 Comment

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Related