Jquery push all li's ID's into array

Question

I need to push all my ID's into an array, both ways I've tried this only pushes the first ID into the array:

  var some = [];
  $('ul#jdLists li').each(function () {
   some.push([$('ul#jdLists li').attr("id")]);
  });

This returns the correct number of items in the array but with the ID of the first li

or

    var some = [];                
    some.push([$('ul#jdLists li').attr("id")]);

this returns a single item with the first li ID

thanks

.attr and other getter methods get the value from the first selected element because there's no way of knowing which element you want to get the attribute from. — Kevin B
– Kevin B, Commented Dec 21, 2012 at 16:30

Zbigniew · Accepted Answer · 2012-12-21 16:27:33Z

11

This piece of code: some.push([$('ul#jdLists li').attr("id")]); will push id of first li found by ul#jdLists li selector, what you need to do is to get id of each li, which can be done inside each function:

var some = [];
$('ul#jdLists li').each(function () {
   some.push($(this).attr("id"));
   // or
   some.push(this.id);
});

answered Dec 21, 2012 at 16:27

Zbigniew

27.6k6 gold badges62 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

amustill Over a year ago

Using some.push(this.id) would save creating a new jQuery object for every element.

Zbigniew Over a year ago

Yeah, I've edited my answer to include it, thanks for comment.

atlMapper Over a year ago

that worked like a charm, thanks I was close but yet still far off

karim79 · Accepted Answer · 2012-12-21 16:28:24Z

4

or you can use $.map():

var ids = $('ul#jdLists li').map(function () {
   return this.id;
}).get();

answered Dec 21, 2012 at 16:28

karim79

343k67 gold badges420 silver badges408 bronze badges

1 Comment

Rory McCrossan Over a year ago

A much more elegant solution IMO

Corneliu · Accepted Answer · 2012-12-21 16:28:45Z

0

var some = [];
$('ul#jdLists li').each(function (i, el) {
   some.push(el.id);
});

answered Dec 21, 2012 at 16:28

Corneliu

2,9521 gold badge21 silver badges23 bronze badges

Collectives™ on Stack Overflow

Jquery push all li's ID's into array

3 Answers 3

3 Comments

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Linked

Related