C++ struct initialization

Question

The following is an abridged version of my Sprite class:

class Sprite
{
    struct SpriteState {
        Vector3 position;
        int width, height;
        double rotation, scaling;
    };
    std::map<int, SpriteState> stateVector;
}

I'd like to create a SpriteState object through a member function that looks something along the lines of the following:

SpriteState newSpriteState(
        Vector3 position = stateVector.rbegin()->second.position, 
        int width = = stateVector.rbegin()->second.width, 
        int height = = stateVector.rbegin()->second.height, 
        double rotation = stateVector.rbegin()->second.rotation, 
        double scaling = stateVector.rbegin()->second.scaling)
    { SpriteState a; a.position = position; a.width = width; a.height = height; a.rotation = rotation; a.scaling = scaling; return a; }

I get the following error:

a nonstatic member reference must be relative to a specific object

The basic idea behind the class itself is to store the various states of the sprite as it changes so that I can easily recover to a previous state if needed.

However, in most cases the Sprite is only updated with new position values while width, height, rotation, and scaling stays pretty much the same - which means I only change the position value while popping up and saving again references from the last state saved for the other values.

I'd hence like to be able to set default values for the function so that I don't have to laboriously write the same values repeatedly.

Any possible ideas on implementation?

int width = = stateVector.rbegin()->second.width ?

billz
– billz

2012-12-19 11:11:08 +00:00
Commented Dec 19, 2012 at 11:11 — billz
– billz, Commented Dec 19, 2012 at 11:11

Pubby · Accepted Answer · 2012-12-19 11:09:42Z

2

Overload it:

SpriteState newSpriteState(Vector3 position)
{
    return newSpriteState(
            position,
            stateVector.rbegin()->second.width, 
            stateVector.rbegin()->second.height, 
            stateVector.rbegin()->second.rotation, 
            stateVector.rbegin()->second.scaling)      
}

answered Dec 19, 2012 at 11:09

Pubby

53.3k13 gold badges147 silver badges186 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bart van Ingen Schenau · Accepted Answer · 2012-12-19 11:24:20Z

Default arguments are evaluated in the context of the caller, so if you need to access a member of your class to get the 'default' value, you can't use default arguments.

On the other hand, you can use overloading to get the same effect:

SpriteState newSpriteState(
    Vector3 position,
    int width,
    int height,
    double rotation,
    double scaling)
{ 
    SpriteState a; 
    a.position = position; 
    a.width = width; 
    a.height = height; 
    a.rotation = rotation; 
    a.scaling = scaling; 
    return a; 
}

SpriteState newSpriteState(
    Vector3 position)
{
    return newSpriteState(position,
                          stateVector.rbegin()->second.width, 
                          stateVector.rbegin()->second.height, 
                          stateVector.rbegin()->second.rotation, 
                          stateVector.rbegin()->second.scaling);
}
/* ... And similar for additional non-default values. */

This would definitely be the more exact approach in implementing this. I eventually chose yiding's answer though for it's brevity. Thanks for the reply - I'll definitely be referencing this on future attempts at similar tasks!

yiding · Accepted Answer · 2012-12-19 11:07:11Z

1

You should make a copy of the SpriteState, and then modify it:

SpriteState newSpriteState(stateVector.rbegin()->second);
newSpriteState.width = someNewWidth;
return newSpriteState;

Every struct and class have by default a copy constructor of the following form:

ClassName(const ClassName&);

Which by default copies the data in the class/struct.

answered Dec 19, 2012 at 11:07

yiding

3,59921 silver badges17 bronze badges

1 Comment

dk123 Over a year ago

I've selected this as the answer for its brevity. Perhaps slightly out of the scope of OOP, but I'd rather keep my code simple. Thanks!

billz · Accepted Answer · 2012-12-19 11:52:32Z

1

Member function can't call class members. You could archive it by doing:

SpriteState newSpriteState(SpriteState sprite_state)        
{ 
  SpriteState a; 
  a.position = position; 
  a.width = width; 
  a.height = height; 
  a.rotation = rotation; 
  a.scaling = scaling; 
  return a; 
}

Then you call this function in another member function:

newSpriteState(stateVector.rbegin()->second);

answered Dec 19, 2012 at 11:52

billz

45.6k9 gold badges87 silver badges103 bronze badges

Collectives™ on Stack Overflow

C++ struct initialization

4 Answers 4

Comments

1 Comment

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

1 Comment

Comments

Related