PHP MySQL: Query with Less Than AND Greater Than

Question

I have the following mysql query in my PHP file:

$shopID   = mysql_real_escape_string($_GET['shop_id']);
$latitudeCenter = mysql_real_escape_string($_GET['lat_center']);
$longtitudeCenter = mysql_real_escape_string($_GET['lng_center']);

$lat_min = $latitudeCenter - 0.045;
$lat_max = $latitudeCenter + 0.045;
$long_min = $longtitudeCenter - (0.045 / cos($latitudeCenter*M_PI/180);
$long_max = $longtitudeCenter + (0.045 / cos($latitudeCenter*M_PI/180);

$sql = "SELECT * FROM shops WHERE shop_id = '$shopID' AND lat >= '$lat_min' AND lat <= '$lat_max' AND lng >= '$long_min' AND lng <= '$long_max'";

For some reason the query is not running successfully. Is the above query valid? Thanks

EDIT:

There is something wrong with the $long_min and $long_max calculations as when they are commented out, it works ok.

Here is the code I tried to conver to PHP:

lat_min = lat_center - 0.045;
lat_max = lat_center + 0.045;
long_min = long_center - (0.045 / Math.cos(lat_center*Math.PI/180);
long_max = long_center + (0.045 / Math.cos(lat_center*Math.PI/180);

What is wrong with my PHP?

Adding the error to your question would help out a lot. echo mysql_error(); after you executed mysql_query($sql);. — Sjaak Trekhaak
– Sjaak Trekhaak, Commented Jul 20, 2012 at 13:48
Please don't use mysql_* functions in new code. They were removed from PHP 7.0.0 in 2015. Instead, use prepared statements via PDO or MySQLi. See Why shouldn't I use mysql_* functions in PHP? for more information. — Madara's Ghost
– Madara's Ghost, Commented Jul 20, 2012 at 13:49

hjpotter92 · Accepted Answer · 2012-07-20 13:51:20Z

2

Use the MySQl's BETWEEN and NEVER use quotes for comparing numbers. So the query becomes:

$sql = "SELECT *
  FROM shops
  WHERE shop_id = $shopID
    AND lat BETWEEN $lat_min AND $lat_max
    AND lng BETWEEN $long_min AND $long_max";

Where, I have considered that shop_id column is auto-incremental number.

answered Jul 20, 2012 at 13:51

hjpotter92

81k36 gold badges148 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user1417302 Over a year ago

thanks this seems correct, shop_id is actually VARCHAR, however i'm still getting a blank white page. I'm thinking there is something wrong with the maths calculations

hjpotter92 Over a year ago

@user1417302 Here is the code I tried to conver to PHP:. Convert the code from where? and Why

user1417302 Over a year ago

From this question: stackoverflow.com/questions/10398481/…

Collectives™ on Stack Overflow

PHP MySQL: Query with Less Than AND Greater Than

1 Answer 1

3 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Linked

Related