Ruby on Rails Syntax Error

Question

I'm new to rails and I can't figure out what's wrong with the syntax - it seems to be getting through the first block (for price) and is giving me an error once I hit 'score' => etc...

<% dataset = { %>
<%  'price' => [@wines.each do |wine| %>
<%                  wine.price_750 %>, 
<%              end].to_vector(:scale),%> 

<%  'score' => [@wines.each do |wine| %>
<%              if current_user.wine_ratings.scoped_by_wine_id(wine.id).exists? %>
<%              current_user.wine_ratings.find_by_wine_id(wine.id).rating_value %>,
<%              else %>
<%                  wine.rating %>,
<%              end%>
<%              end].to_vector(:scale)%>
<% }.to_dataset %>

here's the error message:

index.html.erb:13: syntax error, unexpected ';', expecting tASSOC ');'score' => [@wines.each do |wine|

index.html.erb:13: syntax error, unexpected tASSOC, expecting keyword_end ');'score' => [@wines.each do |wine|

index.html.erb:20: syntax error, unexpected '}', expecting keyword_end }.to_dataset

Anyone know what I'm doing wrong?

alexanderpine · Accepted Answer · 2012-05-19 19:29:13Z

2

I think that you are confused as to MVC programming in general. This kind of code does not belong in the view, rather in either your controller or a view helper, but, in general, try to keep business logic like this to a minimum in your view.

answered May 19, 2012 at 19:29

alexanderpine

1781 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Michael Lee Tyrrell Over a year ago

Yeah, I'm still trying to understand a lot of the basic concepts - I'll try and move it to the controller or view helper. thanks!

alexanderpine Over a year ago

Sorry, didn't mean to be rude or mean at all! :)

Amadan · Accepted Answer · 2012-05-19 19:28:05Z

0

Just a guess, but I would suspect erb is getting confused with the newline, and with all the opening and closing of ERb tags. Try scrapping all but the outermost tags; alternately, try killing the blank line, or surrounding it too with the crazy. I would suggest the first, since it also increases readability, speed of debugging, and people's first impressions :p

answered May 19, 2012 at 19:28

Amadan

199k23 gold badges252 silver badges321 bronze badges

1 Comment

Michael Lee Tyrrell Over a year ago

Killing the blank line got me to another error - so that seemed to be part of the problem. I'll try scrapping the extra erb tags as well - see if that gets me anywhere. Thanks!

Rohit · Accepted Answer · 2012-09-17 14:24:01Z

0

Nor sure if this post is related to your error or not but when I first googled for the error which I was receiving in RoR this question was the first link. So pasting my solution :).

Missing controller Argument Error

answered Sep 17, 2012 at 14:24

Rohit

6,62316 gold badges65 silver badges94 bronze badges

Collectives™ on Stack Overflow

Ruby on Rails Syntax Error

3 Answers 3

2 Comments

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Related