Rails 3 refactoring ActiveRecord query

Question

I have the following query which looks up an organisation belonging to the current signed in user and then finds any events belonging to that organisation.

def update
    @organisation = current_user.organisations.find(params[:organisation_id])
    @event = @organisation.events.find(params[:id])
    if @event.update_attributes(params[:event])
        # Handle a successful update.
        flash[:success] = "Event updated"
        redirect_to organisation_event_path
    else
        render 'edit'
    end
end

This currently results in 2 queries to the database, which whilst not necessarily a problem, I feel should be able to be achieved in one query. Is that possible or does it need to be 2? If the former, how should I go about achieving it?

tommasop · Accepted Answer · 2012-05-11 12:02:27Z

1

The query could be refactored in this way:

def update
    @event = Event.joins(:organisations).where("id = ? AND organisation_id = ? AND user_id = ?", params[:id], params[:organisation_id], current_user.id).first()
    if @event.update_attributes(params[:event])
        # Handle a successful update.
        flash[:success] = "Event updated"
        redirect_to organisation_event_path
    else
        render 'edit'
    end
end

answered May 11, 2012 at 12:02

tommasop

18.8k2 gold badges43 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matzi · Accepted Answer · 2012-05-11 13:51:37Z

1

It should work:

current_user.organisations.joins(:events).where(["id = ? AND events.id = ?", params[:organisation_id], params[:id]]).first()

edited May 11, 2012 at 13:51

answered May 11, 2012 at 11:47

Matzi

14k4 gold badges35 silver badges51 bronze badges

Collectives™ on Stack Overflow

Rails 3 refactoring ActiveRecord query

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related