refactoring code in rails controller

Question

i have two actions in my controller

def up_vote
    lesson = Lesson.find(params[:id])
    current_user.up_vote!(lesson)
    flash[:message] = 'Thanks for voting!'
    redirect_to lesson_path(lesson)
end

def down_vote
    lesson = Lesson.find(params[:id])
    current_user.down_vote!(lesson)
    flash[:message] = 'Thanks for voting!'
    redirect_to lesson_path(lesson)
end

i was wondering what would be a good way to refactor this (keeping DRY in mind)? i read online that i shouldn't be trying to abuse the before_filter. what else could i use then? thanks!

when considering code re factoring, this is a good resource - refactormycode.com — sameera207
– sameera207, Commented Apr 17, 2012 at 6:54

ffoeg · Accepted Answer · 2012-04-17 03:52:56Z

6

def vote_up
  vote(:up)
end

def vote_down
  vote(:down)
end

protected

def vote(direction)
  lesson = Lesson.find(params[:id])
  current_user.send :"#{direction}_vote!",lesson
  flash[:message] = 'Thanks for voting!'
  redirect_to lesson_path(lesson)
end

answered Apr 17, 2012 at 3:52

ffoeg

2,3361 gold badge14 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sasha Over a year ago

thank you for your help! i will keep that idea in mind. ive never seen the .send before

Michael Berkowski · Accepted Answer · 2012-04-17 02:31:10Z

1

Well most obviously would be to use a single method which takes an up_or_down parameter.

def vote(up_or_down)
    lesson = Lesson.find(params[:id])
    if up_or_down.eql? "up"
      current_user.up_vote!(lesson)
    elsif up_or_down.eql? "down"
      current_user.down_vote!(lesson)
    else
      # send an error message or just return
    end
    flash[:message] = 'Thanks for voting!'
    redirect_to lesson_path(lesson)
end

answered Apr 17, 2012 at 2:31

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Collectives™ on Stack Overflow

refactoring code in rails controller

2 Answers 2

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Related