Optional parameter in the function of c#

Question

I have to method in model of my asp.net mvc project.

public JsonResult GetProductsByDepList(string depID)
{
  JsonResult jr = new JsonResult();
  var _product = from a in DataContext.GetProductsByDep(Convert.ToInt32(depID))
  select new { ID = a.ID, ProName = a.Name };
  jr.Data = _product.ToList();
  jr.JsonRequestBehavior = JsonRequestBehavior.AllowGet;
  return jr;
 }


 public JsonResult GetProductByCatList(string depID, string catID)
 {
   JsonResult jr = new JsonResult();
   var _product = from a in   
   DataContext.GetProductsByCat(Convert.ToInt32(depID),Convert.ToInt32(catID))
   select new { ID = a.ID, ProName = a.Name };
   jr.Data = _product.ToList();
   jr.JsonRequestBehavior = JsonRequestBehavior.AllowGet;
   return jr;
 }

I want to combine these 2 method, it is work the same each other, except the parameter of the function.

Any ideas please.

Given that these two methods do different things, why do you want to combine them? — ChrisF
– ChrisF, Commented Apr 10, 2012 at 9:32

Oded · Accepted Answer · 2012-04-10 09:33:16Z

3

Use an optional argument:

public JsonResult GetProductByCatList(string depID, string catID = "0")

answered Apr 10, 2012 at 9:33

Oded

501k102 gold badges899 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tigran · Accepted Answer · 2012-04-10 09:33:03Z

2

 public JsonResult GetProductByCatList(string depID, string catID = "-1")
 {
   //common shared code
   return jr;
 }

Assuming that default value is -1 for catID

answered Apr 10, 2012 at 9:33

Tigran

62.3k8 gold badges90 silver badges124 bronze badges

Comments

Marco · Accepted Answer · 2012-04-10 09:40:40Z

You could try:

public JsonResult GetProductByCatList(string depID, string catID = null)
{
  JsonResult jr = new JsonResult();
  if (String.IsNullOrEmpty(catID))
  {
      var _product = from a in DataContext.GetProductsByDep(Convert.ToInt32(depID))  
      select new { ID = a.ID, ProName = a.Name };
      jr.Data = _product.ToList();      
  } else {
      var _product = from a in   
      DataContext.GetProductsByCat(Convert.ToInt32(depID),Convert.ToInt32(catID))
      select new { ID = a.ID, ProName = a.Name };
      jr.Data = _product.ToList();      
  }
  return jr;
}

ugoa · Accepted Answer · 2012-04-12 23:29:12Z

You can try like this:

   public JsonResult GetProductsByDepList(string depID)
   {
       return GetProductByCatList(depID, null);
   }

   public JsonResult GetProductByCatList(string depID, string catID)
   {
       JsonResult jr = new JsonResult();
       var _product = null;
       if (!string.IsNullOrEmpty(catID))
       {
           _product = from a in   
               DataContext.GetProductsByCat(Convert.ToInt32(depID),Convert.ToInt32(catID))
               select new { ID = a.ID, ProName = a.Name };
       }
       else
       {
           _product = from a in DataContext.GetProductsByDep(Convert.ToInt32(depID))
               select new { ID = a.ID, ProName = a.Name };
       } 

       jr.Data = _product.ToList();
       jr.JsonRequestBehavior = JsonRequestBehavior.AllowGet;
       return jr;
   }

this has errors, you can't declare _product twice and you can't just put the select bit off on it's own after the if/else statements. Also you need a return in the top function.

Aleksej Vasinov · Accepted Answer · 2012-04-10 09:36:51Z

1

Default parameters are available from 4.0 version. Also, read this article from MS http://blogs.msdn.com/b/csharpfaq/archive/2004/03/07/85556.aspx

answered Apr 10, 2012 at 9:36

Aleksej Vasinov

2,80730 silver badges29 bronze badges

Collectives™ on Stack Overflow

Optional parameter in the function of c#

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Related