PHP Shorthand If Else

Question

Is there a way to do the following, but in short if/then syntax:

if($method->isAbstract()) {
   $details['abstract'] = true;
}

If I do:

$details['abstract'] = $method->isAbstract() ? true : null;

It is not quite the same, because the array key abstract is always set. I only way the array key set if isAbstract() is true. To clarify, if isAbstract() is false, don't set the key in the array.

Thanks.

If $method->isAbstract() is false, the array key 'abstract' is going to be defined. I don't want the element to exist in the array if its false. — Justin
– Justin, Commented Apr 9, 2012 at 21:04
Ternary operator IS NOT a shorthand to if-else. Wondered who said it so that so much people think so?! — zerkms
– zerkms, Commented Apr 9, 2012 at 21:04
Whats the matter with the first code? Arent 3 lines short enough? You can write it shorter like if($method->isAbstract()) $details['abstract'] = true;. More interesting: Why should the key completely missing? Why not false? Feels more consistent and it's just a completely obvious $details['abstract'] = $method->isAbstract() — KingCrunch
– KingCrunch, Commented Apr 9, 2012 at 21:07

Mischa Arefiev · Accepted Answer · 2012-04-09 21:06:38Z

4

I don't have a PHP interpreter at hand, but I guess this will work:

$method->isAbstract() && $details['abstract'] = true;

Update: yes, it works → http://codepad.org/lW23FR0j

edited Apr 9, 2012 at 21:06

answered Apr 9, 2012 at 21:05

Mischa Arefiev

5,4574 gold badges28 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

zerkms Over a year ago

Is it a contest of how to write the most difficult-to-understand code?

nico Over a year ago

Sure it works, but I would discourage this type of usage, it is less clear than the if-else version and difficult to maintain

zerkms Over a year ago

@Justin: no, please no! the code should be written for humans, not for interpreter

nico Over a year ago

@Justin: will you still like it in 6 months time?

landons Over a year ago

Justin, use gloves man. thedailywtf.com/Articles/The_Complicator_0x27_s_Gloves.aspx

|

Community · Accepted Answer · 2017-05-23 11:56:27Z

I wouldn't worry too much about trying to shorten three lines of code, which in all honesty could be written in one line anyway:

if ( $obj->method() ) $data['key'] = 'value' ;

However, as @Mischa's answer demonstrated, there are shorter ways. You could use the logical operator && to perform assignment as well:

$obj->method() && $data['key'] = 'value' ;

In this method, the expression on the right is evaluated if the expression on the left is "true".

Another method is the new shorter ternary operator which excludes the second expression. While you presented the long-form ternary as an alternative in your original question, you could also consider the new format provided since PHP 5.3

!$obj->method() ?: $data['key'] = 'value' ;

Since we're not using the second expression, we invert our test in the first expression. No longer checking for a positive, we are now looking for a negative. When the negative is found, our assignment takes place.

I don't provide this answer to encourage you to avoid 3-line solutions, but only to encourage you to feel free to explore shorter solutions from time to time as they often times lead to parts of the language you may not have otherwise discovered.

Collectives™ on Stack Overflow

PHP Shorthand If Else

2 Answers 2

7 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Related