28
votes
Accepted
Code that handles n% of test cases but not all
If the code produces wrong answers for some test cases, then the author is aware that the code is not working correctly as intended, and the question is thus prima facie off-topic for Code Review.
...
- 146k
20
votes
Accepted
Reviewing Programming Challenge requirements and givens
Is it on-topic to review a challenge's requirements? To the extent that the requirements force bad code, Yes.
The core of every question at Code Review is "How can I make this code better?" It is not ...
- 1,036
17
votes
Accepted
"Who Wrote This?" and What Do We Actually Consider Authorship?
I think the close vote is inappropriate.
The close reason says "author or maintainer".
In this case I think it makes sense to assume that the poster is the maintainer of the cloned code,
especially ...
- 113k
16
votes
Are vectorization requests on-topic?
I'm going to come off a bit harsh with this, but wow does that tag need help.
I think that, in the case of vectorization, the tag itself has a lot of problems.
First off, the tag-usage wiki doesn't ...
- 20.3k
15
votes
Are questions with undiscovered bugs allowed?
For this particular case, it's a common beginner error, that wouldn't show up during runtime unless the out-of-bounds reads lead to a win because it happened to look like 4 in a row. I've had plenty ...
- 7,021
14
votes
Are questions with undiscovered bugs allowed?
If you ask yourself:
Can you play a game of connect four with their code?
And your answer is:
Yes, except in some special case - which someone may be unlikely to test.
Then no the question shouldn'...
PeilonrayzMod
- 44.6k
14
votes
Accepted
Acceptability of questions about checking for race conditions
If you know that your code has a race condition then it is broken. Take it home and fix it then bring it back. If it might have a race condition but you just aren't certain then it certainly falls ...
- 2,360
14
votes
Is a changeset reviewable?
I'm not asking to review the code
This alone dismisses the idea of a meta-review as invalid, for me. We only review code. The OP could easily just post the new code and receive valuable feedback about ...
- 71.1k
13
votes
Accepted
I think my code might have a bug, but I am not sure if it actually does, is it broken code?
If that message isn't the intended behavior, and you're looking for a solution to that specific issue, the right thing to do is to post a MCVE that reproduces the problem on Stack Overflow.
If that ...
- 75.6k
12
votes
When are Machine Learning questions on-topic?
I'll replace the "Machine Learning" parts of your question with "code" to keep it simple. After all, that's what it is.
"My code is learning too slow"
But it works, right? If that's the only issue, ...
MastMod
- 13.8k
12
votes
Are vectorization requests on-topic?
Specific question
Since I hammer-closed the question, and I added the comment, let me explain the reasoning I had, starting with a hypothetical case:
Hypothetically, someone asks a question: "this is ...
- 98.2k
12
votes
Accepted
Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)
Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)
Yes, we currently tag questions with python if it runs in a version or both versions of ...
PeilonrayzMod
- 44.6k
12
votes
Accepted
Requesting a comparative review of own code with third-party code
Code Review only allows for reviews of code that is written/maintained by the author. We have that requirement for multiple reasons, including legal (copyright) and moral (to avoid code-shaming).
...
- 146k
11
votes
Accepted
Why is "Building a good C++11 template library - compile-time checked enum array" on-topic?
I have long been uneasy about this opinion that interfaces are reviewable. In my opinion, it conflicts with the current site standard, which is that stub code is off-topic.
I suppose that it might be ...
- 146k
11
votes
Accepted
Are questions mostly unrelated to the presented code on-topic?
Existing rules
These are covered in multiple questions
Question body:
Should a post with no specific question(s) imply a general review?
Should [programming-challenge] questions require a summary of ...
PeilonrayzMod
- 44.6k
11
votes
Accepted
Are responses to specific interview questions on-topic?
My opinion on this issue is that there are many ways for people to get through interviews ahead of other qualified people, it normally comes down to being better prepared for the interview, or being a ...
- 98.2k
10
votes
Confusing phrasing of the "off-topic" close reason
Unfortunately I agree with the close reasons. To the best of your knowledge, your code fails the google test cases, therefore it does not work. Just because you don't know what the problem is, does ...
- 98.2k
10
votes
Are questions with undiscovered bugs allowed?
It is unreasonable to insist that code posted for review has no bugs.
It is reasonable to require that code posted for review has no known bugs.
The rule exists so that we can concentrate on ...
- 88.4k
10
votes
When are Machine Learning questions on-topic?
I think that the nature of the question itself lends to several options. Here are my thoughts based on Simon's examples.
"My Machine Learning is learning too slow"
These would seem to fall into Code ...
- 20.5k
10
votes
Accepted
Technology review without code
No, such a question would not be suitable here if no working code is included. See What topics can I ask about? for reference.
In fact, I don't think there is a site on the Stack Exchange network ...
- 20.5k
10
votes
Question about "Polymorphic implementation of == with CRTP" on hold as off topic
So, do you think my original post it theoretical? or maybe pseudo-code or hypothetical? do you think it is off topic?
Yes, and unclear, since it was lacking a description. In my opinion, it has been ...
MastMod
- 13.8k
10
votes
Caesar Cipher in C++
I can see why the question has been closed. It clearly does not work as intended, the author states:
So essentially I can encrypt a single word, but not a sentence. The
program crashes on me if I ...
- 98.2k
10
votes
Caesar Cipher in C++
As I see it, being nice to new contributors means that we give them more friendly guidance on how to make their questions and answers acceptable for Code Review. It doesn't mean that we lower our ...
- 146k
9
votes
Are questions with undiscovered bugs allowed?
I just voted to Reopen. My reasoning:
As far as the poster knew at the time of posting, the code worked. The code works for most situations. Two people answered, so the poster can't fix the code ...
- 22.4k
9
votes
Accepted
How should we handle answers on non-code questions?
Off topic questions shouldn't get answers. If we're just too slow in closing off-topic questions, they still shouldn't get any answers.
Drop the poster of the answer a comment, indicating that the ...
- 25.5k
9
votes
Are responses to specific interview questions on-topic?
We already have a policy set out from when we discussed homework.
The ethics of answering a homework question before it is handed in
Should we review code that can be used in an unethical/immoral/...
PeilonrayzMod
- 44.6k
9
votes
Why was my post closed? Was I too critical of the original author or looking for confirmation bias?
You should be more careful who you take advice from. On your Stack Overflow post a user with 156 rep, on Code Review, told you to post here. Then a moderator with 25k rep told you your post would not ...
PeilonrayzMod
- 44.6k
9
votes
Accepted
Do questions require specific problems, or are general reviews on-topic?
Yes. "Do I want feedback about any or all facets of the code?" means all questions are open to general reviews, even if you mention a specific aspect you want reviewed. Questions don't need ...
- 88.4k
8
votes
Confusing phrasing of the "off-topic" close reason
The phrasing in the close reason is a long-fought-over compromise.
The Scylla and Charybdis that we are trying to avoid are:
We don't want to turn into a debugging service where people post broken ...
- 50.1k
8
votes
Links in snippets
No, that is not the reason for the closure. Your question was closed because the code doesn't work.
...
- 146k
Only top scored, non community-wiki answers of a minimum length are eligible