Fix errors in SourceBuffer creation when media parsed codec is unsupported #7304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
force-pushed
the
bugfix/use-level-codec-over-parsed-based-on-support-check
branch
from
8a7d247 to
7d79fb9
Compare
robwalch
force-pushed
the
bugfix/use-level-codec-over-parsed-based-on-support-check
branch
from
7d79fb9 to
30f7a55
Compare
robwalch
deleted the
bugfix/use-level-codec-over-parsed-based-on-support-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix errors in SourceBuffer creation when media parsed codec is unsupported
Why is this Pull Request needed?
#7302 shares an asset that somehow worked in v1.5, presumably because of a workaround for bad mp4a parsed codec strings that may have been removed in v1.6.
This change ensures that supported CODECS codec values will be used instead of the mp4 stsd parsed value when the latter fails an isTypeSupported check.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Resolves #7302 and #7355
Checklist