19
votes
Concurrent HashSet
General Stuff
Would be nice to have inline documentation (///) on classes and public members, but everything is pretty simple and understandable. Some might ...
- 7,591
14
votes
Accepted
Porting C-style socket to CPP class
Avoid using malloc() in C++
There are much better ways to allocate memory in C++ that are simpler and safer. First, in C++ you should use ...
- 69.3k
8
votes
Auctionsite API Wrapper in Python
In API.__init__, you're assigning a value to self.base_url. However, that value is never changed and thus is the same for every ...
- 549
6
votes
Auctionsite API Wrapper in Python
Payload
This code is pretty hard to read (and possibly prone to encoding errors):
...
- 8,313
5
votes
Accepted
Executable wrapper around Perl script on Windows
C++
Globally, your C++ seems good enough.
In argvw_of_cmdline you don't have to wrap your second part in a else since you return ...
- 2,411
5
votes
Executable wrapper around Perl script on Windows
Disclaimer
It isn't clear to me what part you want reviews to focus on. I'm not a C++ on Windows person so I can't say much about that part of things. Your C++ is nicely formatted. The ...
- 2,889
5
votes
Accepted
PHP MySQLi wrapper class
This is not much a wrapper. Rather call it a wannabe Query Builder.
I don't know the reason, but many people are constantly trying to write something like this. And I don't understand why.
Okay, for ...
- 9,143
5
votes
Accepted
C++ wrapper class for array of OpenGL buffer objects -- just the constructors
Some specific questions I have about this code/approach are, if applicable,
OK.
Error handling design decision: should the constructors throw, or should I leave error checking, if desired, to the ...
- 97.7k
4
votes
Proxy/Wrapper class for a dynamic object from a SOAP API
this.BasketResponse = new SoapSimplifier(basketResponse).ToJObject();
At this point you know you have a JObject: by ...
- 24.5k
4
votes
Accepted
F# wrapper to generate SHA256 signature for a file
The use binding is usually better than the using function. The object is disposed when leaving the scope of the ...
- 656
4
votes
usart driver wrapper
Consider using enum class
Instead of having a regular enum inside its own namespace, use an ...
- 69.3k
4
votes
Functions in PHP to run basic MySQL crud
Just from a pure useability stand, I don't find these types of wrappers very useful. They work fine for the simplest test cases, but as soon as you want to do a basic join you're back to writing the ...
- 201
4
votes
Auctionsite API Wrapper in Python
Use the start position parameter of .find(...) instead of string slicing
This code uses a string slice:
...
- 113k
4
votes
Accepted
SNTPv4 server based on rfc 4330 in C++
General
It's better to present the files in a more logical order - headers before implementation files, and lower-level utilities before the higher-level code that depends on them.
Address.cpp
The <...
- 88.3k
4
votes
Accepted
OO simple network time server with changes from a previous code inspection and added Windows support
Answers to your questions
Is creating a Makefile to work under Windows a fools errand?
No, it can work fine under Windows. However, installing GNU make on Windows might be an annoying step for some. ...
- 69.3k
4
votes
Accepted
RandomNumber wrapper in Lua
The main issue: side effects
The main issue is that you are using a random which there is only a single seed, shared between any code running on the platform. This is a questionable design by Lua (and ...
- 6,759
3
votes
Executable wrapper around Perl script on Windows
#undef NDEBUG needs to be done before the point at which you #include <cassert>.
- 12.2k
3
votes
Accepted
Automatic exception wrapper in java
Alas, what you would like to do is not possible. You could indeed play around with interceptors in a CDI container or with an AOP framework, and basically change the exception type at runtime. BUT ...
- 5,002
3
votes
3
votes
Accepted
Wrapper for a raw array so that it can be passed to templates expecting Standard Library containers
Array_Wrapper::const_pointer is the same as T *const (const pointer to T), instead of the ...
- 6,528
3
votes
An iterator wrapper that on dereferencing, returns the value of a member (function)
If you have access to C++20, then similar functionality is available using transform_view. The equivalent program becomes just:
...
- 88.3k
3
votes
An iterator wrapper that on dereferencing, returns the value of a member (function)
Removing const qualifier of a Container& container argument in get_member_begin and <...
3
votes
Accepted
OpenGL 4.5 Core Buffer wrapper
template<GLenum target>
As I've explained elsewhere, buffer objects are not typed. There's no such thing as a "vertex buffer object", "transform feedback ...
- 154
3
votes
Accepted
Linux/Mac hashing SHA-1
There's not a huge amount to review here.
It looks like the Apple code is intended to be a drop-in replacement for OpenSSL, so you could probably just rename to match, rather than creating a new name:
...
- 88.3k
3
votes
Automatic RAII wrapper for concurrent access
template<
typename T,
typename _TMtx,
Get off the standard library's lawn! _Ugly names are reserved to the ...
- 578
3
votes
Accepted
Universal OpenGL object RAII wrapper class
Ensuring you have distinct types
You said this in the comments:
I thought that use of templates instead of a common base class would better emphasize that these objects shouldn't be mixed together (...
- 69.3k
3
votes
Accepted
Wrapper for LeagueAPI in Node.js
I've taken a look at other Node Code Reviews and done some research;
Use Promises instead of Callbacks. This should be an easy change, just implement a Promise in the ...
- 2,446
3
votes
Accepted
C++ wrapper around uniform mt19937 SequenceContainer
gen and dist don't need to be pointers. Just declare them as members, and use the member initializer list in the constructor to ...
- 7,821
Only top scored, non community-wiki answers of a minimum length are eligible