Streamline code for checking if a directory exists and saving a file

Question

I hate this code. What is the slickest way to write the following:

MyFile = f;
SaveFolder = Server.MapPath("\\") + "returns\\";
if(!System.IO.Directory.Exists(SaveFolder) )
{
    System.IO.Directory.CreateDirectory(SaveFolder);
}
MyFile.SaveAs(SaveFolder + "2011" + "000-00-0000" + ".xlsx");

What exactly do you hate about this code? Are you looking for a 1-line version of it? — carlosfigueira
– carlosfigueira, Commented May 23, 2011 at 21:43

Ry- · Accepted Answer · 2011-05-24 01:02:06Z

8

Since CreateDirectory does nothing if a directory already exists, you can do this:

MyFile = f;
SaveFolder = Path.Combine(Server.MapPath("\\"), "returns");
System.IO.Directory.CreateDirectory(SaveFolder);
MyFile.SaveAs(SaveFolder, "2011000-00-0000.xlsx");

answered May 24, 2011 at 1:02

Ry-

8654 silver badges13 bronze badges

Add a comment |

Keith Nicholas · Accepted Answer · 2011-05-23 21:40:40Z

6

well, for starters, use Path.Combine... eg :-

SaveFolder = Path.Combine(Server.MapPath(@"\"),"returns");

same kind of thing for building your file name.

answered May 23, 2011 at 21:40

Keith Nicholas

1,62510 silver badges16 bronze badges

\$\begingroup\$ I'm not using 4.0 \$\endgroup\$

MVCylon
– MVCylon

2011-05-24 12:53:20 +00:00
Commented May 24, 2011 at 12:53
6

\$\begingroup\$ Thats ok, they were nice enough to build it into .NET since 1.1 I think \$\endgroup\$

Keith Nicholas
– Keith Nicholas

2011-05-24 21:33:17 +00:00
Commented May 24, 2011 at 21:33
\$\begingroup\$ It's burried in under System.IO :) \$\endgroup\$

Stuart Blackler
– Stuart Blackler

2011-05-24 21:49:45 +00:00
Commented May 24, 2011 at 21:49
\$\begingroup\$ You may be right. However, check out Microsoft's own documentation..msdn.microsoft.com/en-us/library/system.io.path.combine.aspx It only lists .Net 4.0 & Silverlight I googled this BEFORE, I posted that I wasn't using 4.0 \$\endgroup\$

MVCylon
– MVCylon

2011-05-25 12:11:59 +00:00
Commented May 25, 2011 at 12:11
\$\begingroup\$ @MVCylon msdn isn't maybe that clear about it, but the trick is, only one Combine override was available pre .Net 4 - msdn.microsoft.com/en-us/library/fyy7a5kt(v=vs.80).aspx that's why you could choose it \$\endgroup\$

peter
– peter

2016-07-11 20:57:44 +00:00
Commented Jul 11, 2016 at 20:57

Add a comment |

Stack Exchange Network

Streamline code for checking if a directory exists and saving a file

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Streamline code for checking if a directory exists and saving a file

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions