Simpletron in C without initial storing [closed]

Your instruction list:

#define READ 10;
#define WRITE 11;
#define LOAD 20;
#define STORE 21;
#define ADD 30;
#define SUBTRACT 31;
#define DIVIDE 32;
#define MULTIPLY 33;
#define BRANCH 40;
#define BRANCHANG 41;
#define BRANCHZERO 42;
#define HALT 43;

has a few issues. First of all, you shouldn't add semicolons after those defines. Also, this would be better represented as an enum, since op codes are mutually exclusive.

Your memory initialization:

int memory[100] = {2022,1022,3022,2122,2021,3120,2121,4209,4000,1122,4300}; // my set of instruction for sum 10 numbers

also needs a few adjustments. Since none of these values will exceed 9999, you should be storing them as int16_t, not int. Furthermore, you shouldn't be writing raw machine code in that array. You should be constructing those values like

{
    100*LOAD + 22,
    100*READ + 22,
    // ...
}

Also, it seems like you store -99999 as a magic value to indicate program termination, when this is technically not necessary. I don't have the specifications for your VM, but it would make more sense to

• have all of the memory contents be of type int16_t
• on HALT, simply terminate the program

rather than

• on HALT, jump to the end of memory
• at the end of memory, have a magic negative value.

There's a typo in instRegistrer. It's "register", not "registrer".

I propose that, instead of having to manually write a different printf string for each instruction,

1. declare an array of 44 character pointers
2. define a macro that indexes into the array based on the opcode value, and initializes that element to a stringized (#) version of the opcode
3. call the macro for every opcode that you have

You could take this strategy further and store a struct at each element of the array, containing a string name and an operation function pointer. This would nicely generalize your code and make execution of long programs faster.

You're also keen on avoiding separate assignment of memory contents for use by variables. This can be done by shifting your "data" memory to the address right after your "program" memory, and then doing the initialization in your array literal.

The following incorporates all of the above. It seems you're still learning basic C, so some of these concepts may require explanation - please let me know in the comments.

#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>

typedef enum
{
    READ = 10,
    WRIT = 11,
    LOAD = 20,
    STOR = 21,
    ADD = 30,
    SUB = 31,
    DIV = 32,
    MUL = 33,
    BRA = 40,
    BRNG = 41,
    BRZR = 42,
    HALT = 43
} OpCode;

typedef struct
{
    int16_t mem[100], acc;
    uint8_t counter;
} VM;

typedef struct
{
    const char *name;
    void (*execute)(VM *vm, uint8_t addr);
} Operation;

static uint16_t makeOp(OpCode code, uint8_t addr)
{
    return 100*code + addr;
}

#define DEFOP(op) ops[op] = (Operation){.name=#op, .execute=exc_##op}

static void exc_READ(VM *vm, uint8_t addr) {
    int32_t x;
    if (scanf("%d", &x) != 1)
    {
        perror("Failed to read integer");
        exit(1);
    }
    if (x >= 10000 || x <= -10000)
    {
        fprintf(stderr, "Invalid value %d", x);
        exit(1);
    }
    vm->mem[addr] = x;
    vm->counter++;
}
static void exc_WRIT(VM *vm, uint8_t addr) {
    printf("%d\n", vm->mem[addr]);
    vm->counter++;
}
static void exc_LOAD(VM *vm, uint8_t addr) {
    vm->acc = vm->mem[addr];
    vm->counter++;
}
static void exc_STOR(VM *vm, uint8_t addr) {
    vm->mem[addr] = vm->acc;
    vm->counter++;
}
static void exc_ADD(VM *vm, uint8_t addr) {
    vm->acc += vm->mem[addr];
    vm->counter++;
}
static void exc_SUB(VM *vm, uint8_t addr) {
    vm->acc -= vm->mem[addr];
    vm->counter++;
}
static void exc_DIV(VM *vm, uint8_t addr) {
    vm->acc /= vm->mem[addr];
    vm->counter++;
}
static void exc_MUL(VM *vm, uint8_t addr) {
    vm->acc *= vm->mem[addr];
    vm->counter++;
}
static void exc_BRA(VM *vm, uint8_t addr) {
    vm->counter = addr;
}
static void exc_BRNG(VM *vm, uint8_t addr) {
    if (vm->acc < 0)
        vm->counter = addr;
    else
        vm->counter++;
}
static void exc_BRZR(VM *vm, uint8_t addr) {
    if (!vm->acc)
        vm->counter = addr;
    else
        vm->counter++;
}
static void exc_HALT(VM *vm, uint8_t addr) {
    exit(0);
}

int main()
{
    const uint8_t X = 13, I = 12, DELTA = 11;

    Operation ops[HALT+1];
    DEFOP(READ);
    DEFOP(WRIT);
    DEFOP(LOAD);
    DEFOP(STOR);
    DEFOP(ADD);
    DEFOP(SUB);
    DEFOP(DIV);
    DEFOP(MUL);
    DEFOP(BRA);
    DEFOP(BRNG);
    DEFOP(BRZR);
    DEFOP(HALT);

    VM vm = {.counter = 0,
             .acc = 0,
             .mem = {
                makeOp(LOAD, X), // 0: beginning
                makeOp(READ, X),
                makeOp( ADD, X),
                makeOp(STOR, X),
                makeOp(LOAD, I),
                makeOp( SUB, DELTA),
                makeOp(STOR, I),
                makeOp(BRZR, 9),
                makeOp( BRA, 0),
                makeOp(WRIT, X), // 9: exit loop
                makeOp(HALT, 0),
                1,  // 11: DELTA
                10, // 12: I
                0   // 13: X
             }};

    for (;;) {
        int16_t current = vm.mem[vm.counter];
        uint8_t code = current/100,
                addr = current%100;
        const Operation *op = ops + code;
        printf("%02u: %4s %02u\n", vm.counter, op->name, addr);
        op->execute(&vm, addr);
    }
}