Skip to content

feat(spanner): add client_options to base class #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2020
Merged

feat(spanner): add client_options to base class #132

merged 3 commits into from
Aug 14, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Aug 10, 2020

Fixes #116 🦕
@HemangChothani HemangChothani requested a review from a team as a code owner August 10, 2020 13:57
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
larkee
larkee approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor things
busunkim96
busunkim96 approved these changes Aug 12, 2020
View reviewed changes
@HemangChothani HemangChothani mentioned this pull request Aug 13, 2020
Closed
@tseaver tseaver merged commit 6851bb8 into googleapis:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants

@HemangChothani @busunkim96 @larkee @tseaver