fix: do not cause a failure when encountering no bindings#1177
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
frankyn
force-pushed
the
address-iam-policy
branch
from
f8b96b5 to
3af0bfb
Compare
BenWhitehead
approved these changes
Dec 14, 2021
Collaborator
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
The code changes look good to me. For the javadoc updates, we might want to get someone from the writing team to take a look and see if the voice we're using make sense.
cbonnie
approved these changes
Dec 14, 2021
| * Gets the IAM policy for the provided bucket. | ||
| * | ||
| * <p>It's possible for bindings to be empty and instead have permissions inherited through | ||
| * Project or Organization IAM Policies. To prevent corrupting policies when performing a {@code |
There was a problem hiding this comment.
"To prevent corrupting policies when you update an IAM policy with {@code Storage.setIamPolicy, the ETAG value..."
| /** | ||
| * Updates the IAM policy on the specified bucket. | ||
| * | ||
| * <p>To prevent corrupting policies when performing a {@code Storage.setIamPolicy}, the ETAG |
frankyn
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
frankyn
added a commit
that referenced
this pull request
Feb 12, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #1175 ☕️
frankyn
added a commit
that referenced
this pull request
Feb 12, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #1175 ☕️
frankyn
added a commit
that referenced
this pull request
Feb 12, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #1175 ☕️
BenWhitehead
pushed a commit
that referenced
this pull request
Feb 15, 2022
) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #1175 ☕️
frankyn
added a commit
that referenced
this pull request
Feb 15, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #1175 ☕️
frankyn
added a commit
that referenced
this pull request
Feb 15, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Appropriate docs were updated (if necessary) Fixes #1175 ☕️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1175 ☕️