feat: support encoded credentials in connection URL #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables a user to specify a base64 encoded JSON string that contains the credentials that should be used for the connection. This removes the requirement to write the JSON string to a file before it can be used for a connection. Fixes googleapis/java-spanner-jdbc#486
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
thiagotnunes
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a user to specify a base64 encoded JSON string that contains the credentials that should be used for the connection. This removes the requirement to write the JSON string to a file before it can be used for a connection.
This property is the same as the
spring.cloud.gcp.spanner.credentials.encoded-keyproperty that is supported by spring-data-cloud-spanner.Fixes googleapis/java-spanner-jdbc#486