Skip to content

Commit f4fa6bf

Browse files
authored
fix: test allowed a too old staleness (#214)
1 parent 1ec0f34 commit f4fa6bf

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

google-cloud-spanner/src/test/resources/com/google/cloud/spanner/connection/ITReadOnlySpannerTest.sql

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ NEW_CONNECTION;
2020
@EXPECT RESULT_SET 'READONLY',true
2121
SHOW VARIABLE READONLY;
2222

23+
-- Check initial contents.
2324
@EXPECT RESULT_SET
2425
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
2526

27+
-- Check initial contents.
2628
@EXPECT RESULT_SET
2729
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
2830

@@ -72,12 +74,14 @@ SELECT CURRENT_TIMESTAMP();
7274

7375
SET READ_ONLY_STALENESS = 'READ_TIMESTAMP %%CURRENT_TIMESTAMP%%';
7476

77+
-- Check SELECT with READ_TIMESTAMP
7578
@EXPECT RESULT_SET
7679
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
7780

7881
@PUT 'READ_TIMESTAMP1'
7982
SHOW VARIABLE READ_TIMESTAMP;
8083

84+
-- Check SELECT with READ_TIMESTAMP
8185
@EXPECT RESULT_SET
8286
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
8387

@@ -95,12 +99,14 @@ SELECT CURRENT_TIMESTAMP();
9599

96100
SET READ_ONLY_STALENESS = 'MIN_READ_TIMESTAMP %%CURRENT_TIMESTAMP%%';
97101

102+
-- Check SELECT with MIN_READ_TIMESTAMP
98103
@EXPECT RESULT_SET
99104
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
100105

101106
@EXPECT RESULT_SET 'READ_TIMESTAMP'
102107
SHOW VARIABLE READ_TIMESTAMP;
103108

109+
-- Check SELECT with MIN_READ_TIMESTAMP
104110
@EXPECT RESULT_SET
105111
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
106112

@@ -113,12 +119,14 @@ NEW_CONNECTION;
113119

114120
SET READ_ONLY_STALENESS = 'EXACT_STALENESS 1ms';
115121

122+
-- Check SELECT with EXACT_STALENESS
116123
@EXPECT RESULT_SET
117124
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
118125

119126
@EXPECT RESULT_SET 'READ_TIMESTAMP'
120127
SHOW VARIABLE READ_TIMESTAMP;
121128

129+
-- Check SELECT with EXACT_STALENESS
122130
@EXPECT RESULT_SET
123131
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
124132

@@ -127,16 +135,18 @@ SHOW VARIABLE READ_TIMESTAMP;
127135

128136

129137
NEW_CONNECTION;
130-
--TimestampBound.ofMaxStaleness(10, TimeUnit.SECONDS)
138+
--TimestampBound.ofMaxStaleness(100, TimeUnit.MILLISECONDS)
131139

132-
SET READ_ONLY_STALENESS = 'MAX_STALENESS 10s';
140+
SET READ_ONLY_STALENESS = 'MAX_STALENESS 100ms';
133141

142+
-- Check SELECT with MAX_STALENESS
134143
@EXPECT RESULT_SET
135144
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
136145

137146
@EXPECT RESULT_SET 'READ_TIMESTAMP'
138147
SHOW VARIABLE READ_TIMESTAMP;
139148

149+
-- Check SELECT with MAX_STALENESS
140150
@EXPECT RESULT_SET
141151
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
142152

@@ -149,12 +159,14 @@ NEW_CONNECTION;
149159

150160
SET READ_ONLY_STALENESS = 'STRONG';
151161

162+
-- Check SELECT with STRONG
152163
@EXPECT RESULT_SET
153164
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
154165

155166
@EXPECT RESULT_SET 'READ_TIMESTAMP'
156167
SHOW VARIABLE READ_TIMESTAMP;
157168

169+
-- Check SELECT with STRONG
158170
@EXPECT RESULT_SET
159171
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
160172

@@ -178,12 +190,14 @@ SET AUTOCOMMIT = FALSE;
178190

179191
SET READ_ONLY_STALENESS = 'READ_TIMESTAMP %%CURRENT_TIMESTAMP%%';
180192

193+
-- Check SELECT with READ_TIMESTAMP in a transaction.
181194
@EXPECT RESULT_SET
182195
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
183196

184197
@PUT 'READ_TIMESTAMP1'
185198
SHOW VARIABLE READ_TIMESTAMP;
186199

200+
-- Check SELECT with READ_TIMESTAMP in a transaction.
187201
@EXPECT RESULT_SET
188202
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
189203

@@ -213,12 +227,14 @@ SET AUTOCOMMIT = FALSE;
213227

214228
SET READ_ONLY_STALENESS = 'EXACT_STALENESS 100ms';
215229

230+
-- Check SELECT with EXACT_STALENESS in a transaction.
216231
@EXPECT RESULT_SET
217232
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
218233

219234
@PUT 'READ_TIMESTAMP1'
220235
SHOW VARIABLE READ_TIMESTAMP;
221236

237+
-- Check SELECT with EXACT_STALENESS in a transaction.
222238
@EXPECT RESULT_SET
223239
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
224240

@@ -231,11 +247,11 @@ COMMIT;
231247

232248

233249
NEW_CONNECTION;
234-
--TimestampBound.ofMaxStaleness(10, TimeUnit.SECONDS)
250+
--TimestampBound.ofMaxStaleness(100, TimeUnit.MILLISECONDS)
235251
SET AUTOCOMMIT = FALSE;
236252

237253
@EXPECT EXCEPTION FAILED_PRECONDITION
238-
SET READ_ONLY_STALENESS = 'MAX_STALENESS 10s';
254+
SET READ_ONLY_STALENESS = 'MAX_STALENESS 100ms';
239255

240256

241257
NEW_CONNECTION;
@@ -244,12 +260,14 @@ SET AUTOCOMMIT = FALSE;
244260

245261
SET READ_ONLY_STALENESS = 'STRONG';
246262

263+
-- Check SELECT with STRONG in a transaction.
247264
@EXPECT RESULT_SET
248265
SELECT COUNT(*) AS ACTUAL, 1000 AS EXPECTED FROM NUMBERS;
249266

250267
@PUT 'READ_TIMESTAMP1'
251268
SHOW VARIABLE READ_TIMESTAMP;
252269

270+
-- Check SELECT with STRONG in a transaction.
253271
@EXPECT RESULT_SET
254272
SELECT COUNT(*) AS ACTUAL, 168 AS EXPECTED FROM PRIME_NUMBERS;
255273

0 commit comments

Comments
 (0)