[23.0 backport] improve cp progress #4157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a case where a non-tty will have control characters + the log line for every single read operation. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit f27927d) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
- Instead of rewriting the entire line every time only clear and write the parts that changed. - Hide the cursor while writing progress Both these things make the progress updates significantly easier to read. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit ccae6e9) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This just makes it easier to reason about what is happening. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit efd011b) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Only show progress updates after a time threshold has elapsed in order to reduce the number of writes to the terminal. This improves readability of the progress. Also moves cursor show/hide into the progress printer to reduce chances if messing up the user's terminal in case of cancellation. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 90b7bc3) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit b9a1b09) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This moves all the terminal writing to a goroutine that updates the terminal periodically. In our MITM copier we just use an atomic to add to the total number of bytes read/written, the goroutine reads the total and updates the terminal as needed. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit eb392ff) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
vvoland
approved these changes
Apr 4, 2023
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #4137