The Wayback Machine - https://web.archive.org/web/20260314081558/https://github.com/docker/cli/pull/757
Skip to content

Return errors from client in stack deploy configs#757

Merged
vdemeester merged 1 commit intodocker:masterfrom
fp-pszczekutowicz:master
Dec 19, 2017
Merged

Return errors from client in stack deploy configs#757
vdemeester merged 1 commit intodocker:masterfrom
fp-pszczekutowicz:master

Conversation

@fp-pszczekutowicz
Copy link

- What I did
Fixed #756

- How I did it
Added return statement.

- How to verify it

  1. Create stack with service and config
  2. Deploy stack
  3. Update config file content
  4. Deploy stack
  5. Deploy should end with error

- Description for the changelog
Return errors from daemon on stack deploy configs create/update

Signed-off-by: Paweł Szczekutowicz <pszczekutowicz@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

Merging #757 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@docker docker deleted a comment from GordonTheTurtle Dec 19, 2017
@vdemeester vdemeester merged commit 2b8eb23 into docker:master Dec 19, 2017
@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 19, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Return errors from client in stack deploy configs
Upstream-commit: 2b8eb23
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment