Set APIVersion on the client, even when Ping fails#546
Merged
cpuguy83 merged 1 commit intodocker:masterfrom Sep 23, 2017
Merged
Set APIVersion on the client, even when Ping fails#546cpuguy83 merged 1 commit intodocker:masterfrom
cpuguy83 merged 1 commit intodocker:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 49.08% 49.23% +0.14%
==========================================
Files 200 200
Lines 16447 16453 +6
==========================================
+ Hits 8073 8100 +27
+ Misses 7954 7933 -21
Partials 420 420 |
vdemeester
approved these changes
Sep 21, 2017
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐄 Just one question 👼
cli/command/cli_test.go
Outdated
| t.Run(testcase.doc, func(t *testing.T) { | ||
| passRetriever := func(_, _ string, _ bool, attempts int) (passphrase string, giveup bool, err error) { | ||
| switch attempts { | ||
| case 0, 1, 2: |
Collaborator
There was a problem hiding this comment.
Not sure I understand why those are here — well, it's for notary.passRetriever I guess, but those magic number do not help me why we should fail the 3 first time 😅
Contributor
Author
There was a problem hiding this comment.
There's really no significance, it could also be just 0
Refactor to support testing Also add tests Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
fix-version-on-failure
branch
from
36cb146 to
e828efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
Refactor to support testing
Also add tests