The Wayback Machine - https://web.archive.org/web/20251014182242/https://github.com/docker/cli/pull/6399
Skip to content

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Aug 29, 2025

- What I did
Negative serial number certificates are deprecated and Go has also since deprecated them. To use them with Go you need to pass in the GODEBUG=x509negativeserial=1 environment variable.

This PR allows setting the value inside docker context instead. This should then propagate environment variables to underlying plugins (such as buildx).

{
  "Name": "my-context",
  "Metadata": { "GODEBUG": "x509negativeserial=1" },
  "Endpoints": {
    "docker": { "Host": "unix:///var/run/docker.sock", "SkipTLSVerify": false }
  }
}

- How I did it

- How to verify it

- Human readable description for the release notes

Allow Docker CLI to set the `GODEBUG` environment variable when the key-value pair (`"GODEBUG":"..."`) exists inside the docker context metadata.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
(cherry picked from commit 7d7a7aa)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
(cherry picked from commit 65a6c35)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
(cherry picked from commit 467305f)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
(cherry picked from commit 6163c03)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
(cherry picked from commit 72f7933)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/cli.go 55.26% 15 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sorry, looks like I missed that it could've used some squashing

@vvoland vvoland merged commit aced30d into docker:28.x Aug 29, 2025
118 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment