Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
image/inspect: Add --platform flag #5934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
18 tasks
vvoland
force-pushed
the
inspect-platform
branch
from
99a757c to
1255d87
Compare
thaJeztah
reviewed
Apr 11, 2025
Comment on lines
+46
to
+48
| // Don't default to DOCKER_DEFAULT_PLATFORM env variable, always default to | ||
| // inspecting the image as-is. This also avoids forcing the platform selection | ||
| // on older APIs which don't support it. |
There was a problem hiding this comment.
Yeah, we need to get rid of that magic "addplatform flags" function.
thaJeztah
reviewed
Apr 11, 2025
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
inspect-platform
branch
from
1255d87 to
0d9d187
Compare
thaJeztah
reviewed
Apr 11, 2025
Comment on lines
+71
to
+74
| resp, err := apiClient.ImageInspect(ctx, ref, | ||
| client.ImageInspectWithRawResponse(&buf), | ||
| client.ImageInspectWithPlatform(platform), | ||
| ) |
There was a problem hiding this comment.
The alternative would be to collect a list of opts and append if set, but this is fine for now I think 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)