Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
builder: validate buildkit configuration #2864
Conversation
crazy-max
force-pushed
the
builder-validate-config
branch
from
ac887c6 to
861f42a
Compare
| if err != nil { | ||
| return t, errors.Wrap(err, "failed to parse config") | ||
| return t, errors.Wrap(err, "failed to parse buildkit config") | ||
| } |
There was a problem hiding this comment.
Wondering; will this be problematic when crating a builder using an older version of buildkit? (i.e. would validation only work correctly if the version matches the one that's vendored?)
There was a problem hiding this comment.
I don't think this will be an issue as we are backward compat. Also we are already using this logic to get the registry config in
buildx/store/storeutil/storeutil.go
Lines 125 to 128 in 567361d
There was a problem hiding this comment.
Ah yeah, I wasn't sure, so thought I'd mention it. I recall that I ran into changes in the garbage-collect configuration that changed, and for which I needed to make changes in moby/moby, because it used those; moby/moby#48634 (comment)
There was a problem hiding this comment.
Can we add a test for this, making sure a new unknown key doesn't cause a validation error.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
builder-validate-config
branch
from
861f42a to
07db2be
Compare
4 participants
fixes #2853
We should validate buildkit configuration before creating the builder.