The Wayback Machine - https://web.archive.org/web/20251107075714/https://github.com/docker/buildx/pull/2492/
Skip to content

k8s: opt to customize timeout during deployment #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2024
Merged

k8s: opt to customize timeout during deployment #2492

merged 2 commits into from
Jun 3, 2024

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jun 3, 2024 •
edited
Loading

closes #2457
closes #2472

carry #2457 with some changes to rename provisioningTimeout to timeout and also remove the attribute from deployment manifest that is not actually used.

needs docs follow-up in: https://docs.docker.com/build/drivers/kubernetes/ (cc @dvdksn)

test: https://github.com/docker/buildx/actions/runs/9346931610/job/25722907636?pr=2492#step:9:19

#1 [internal] booting buildkit
#1 waiting for 1 pods to be ready, timeout: 2 minutes
#1 waiting for 1 pods to be ready, timeout: 2 minutes 25.8s done

cc @Arsobbiak @ali-kafel
Arsobbiak and others added 2 commits June 3, 2024 10:08
@Arsobbiak @crazy-max
Add parameter provisioningTimeout to Kubernetes driver options.
53b7cbc 
Signed-off-by: Arnold Sobanski <arnold@l4g.dev>
@crazy-max
k8s: rename timeout opt and move it out of deployment manifest
f30e143 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review June 3, 2024 08:44
@crazy-max crazy-max added this to the v0.15.0 milestone Jun 3, 2024
dvdksn
dvdksn reviewed Jun 3, 2024
View reviewed changes
driver/kubernetes/factory_test.go
"replicas": "invalid",
}
_, _, _, _, err := f.processDriverOpts(cfg.Name, "test", cfg)
_, _, _, _, _, err := f.processDriverOpts(cfg.Name, "test", cfg)
Copy link
Contributor

@dvdksn dvdksn Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it
Copy link
Member Author

@crazy-max crazy-max Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need to review processDriverOpts func 🙈
@crazy-max crazy-max merged commit 947d602 into docker:master Jun 3, 2024
@crazy-max crazy-max deleted the k8s-timeout branch June 3, 2024 14:26
@crazy-max crazy-max mentioned this pull request Jun 11, 2024
Merged
@dvdksn dvdksn mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/driver/kubernetes area/driver status/code-review

5 participants

@crazy-max @AkihiroSuda @dvdksn @ali-kafel @Arsobbiak