Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix k8s driver with certs cannot boot #2454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
crazy-max
reviewed
May 14, 2024
There was a problem hiding this comment.
Not really familiar with k8s deployments but looking at changes in #787 and follow-up for k8s driver in #824, it looks good.
PTAL @tonistiigi @morlay
| d.Spec.Template.Spec.Volumes = []corev1.Volume{{ | ||
| Name: "config", | ||
| d.Spec.Template.Spec.Volumes = append(d.Spec.Template.Spec.Volumes, corev1.Volume{ | ||
| Name: cfg.name, |
There was a problem hiding this comment.
Seems fine to use cfg.name here. Might have been an oversight in #824 (cc @tonistiigi @morlay)
crazy-max
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a self-signed certificate is specified in
buildkitd.toml, the current implementation registers the certificate as aConfigMap, but thevolumesandvolumeMountsinDeploymentare incorrect, so theDeploymetntcannot start.This fixes #1800.