The Wayback Machine - https://web.archive.org/web/20221224082625/https://github.com/websockets/ws/issues/613
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose close callback #613

Open
coolaj86 opened this issue Nov 9, 2015 · 5 comments
Open

expose close callback #613

coolaj86 opened this issue Nov 9, 2015 · 5 comments

Comments

@coolaj86
Copy link
Contributor

coolaj86 commented Nov 9, 2015

You have a .close(code, data) method here:
https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L100

But you don't expose the callback here:
https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L121
@coolaj86
Copy link
Contributor Author

coolaj86 commented Nov 9, 2015

I patched it such that if the callback is supplied it uses the callback for error instead of emitting.

#614
@Eeems
Copy link

Eeems commented Nov 26, 2015

Your pull request is failing the code checks. You'll want to update it to keep from failing. It will hopefully get merged after that?
@nikelborm
Copy link

nikelborm commented Jan 11, 2020

Screenshot_3
It`s my problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@coolaj86 @Eeems @nikelborm and others