Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix bar overlap bug when tick fit is false #2306
Conversation
…W to calculate unique x values
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 74.92% 74.95% +0.03%
==========================================
Files 51 51
Lines 4227 4233 +6
==========================================
+ Hits 3167 3173 +6
Misses 1060 1060
Continue to review full report at Codecov.
|
|
@rkrabek Thanks for your contribution. Could you add some to tests to ensure this is actually fixing something? I tried your fix with the following config: http://jsfiddle.net/moeumaj7/3/ And in this case it's actually break the display. |
… tick count, adds tests for bar width when tick fit is false
|
@panthony Sorry for the delayed response, I've been super busy at work. I've updated the PR to include tests for bar width when tick fit is false. The config that you provided: http://jsfiddle.net/moeumaj7/3/ fails with my patch for the same reason it fails when you switch tick/fit to true as shown here: http://jsfiddle.net/ox76hL53/ This patch aims to fix this scenario (with or without the null data points): http://jsfiddle.net/dtttsa9d/ |
Partial fix for issue #1386
If tick fit is set to false and there are many values, the bars overlap because the bar width is currently calculated based on how many ticks there are instead of the data points.