The Wayback Machine - https://web.archive.org/web/20240910141034/https://github.com/nodejs/node/pull/54642
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: reset event state after dispatch #54642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

events: reset event state after dispatch #54642

wants to merge 2 commits into from

Conversation

KhafraDev
Copy link
Member

Fixes #54617
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 29, 2024
KhafraDev
KhafraDev commented Aug 29, 2024
View reviewed changes
test/fixtures/wpt/dom/events/EventTarget-constructible.any.js
assert_equals(event.target, target);
assert_equals(event.currentTarget, null);
assert_array_equals(event.composedPath(), []);
}, "A constructed EventTarget implements dispatch correctly");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test that checks the behavior. Afaict event.target -> not reset after dispatch; event.currentTarget -> reset after dispatch.
@KhafraDev KhafraDev added the eventtarget Issues and PRs related to the EventTarget implementation. label Aug 29, 2024
@RedYetiDev
Copy link
Member

Could you either drop the WPT update (if so, it'll be done in #54468), or split this into two commits?

Thank you
@RedYetiDev RedYetiDev added the web-standards Issues and PRs related to Web APIs label Aug 29, 2024
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@KhafraDev
Copy link
Member Author

I split into two commits so we can test the change.
@RedYetiDev RedYetiDev added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Aug 29, 2024
@KhafraDev KhafraDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@KhafraDev KhafraDev added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@KhafraDev KhafraDev added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@KhafraDev
Copy link
Member Author

I'm honestly a few CI runs from giving up
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@KhafraDev
Copy link
Member Author

9th time's the charm
@anonrig
Copy link
Member

anonrig commented Sep 6, 2024

I went ahead and visited all failed builds on this PR and added them as flaky on my PR #54802
@KhafraDev
Copy link
Member Author

10th time might actually be it then
@KhafraDev
Copy link
Member Author

If the CI doesn't pass here I am no longer going to bother with this PR
@KhafraDev KhafraDev added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62095/
@jasnell
Copy link
Member

jasnell commented Sep 8, 2024

PR is currently blocked from landing by unreliable CI.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62157/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. eventtarget Issues and PRs related to the EventTarget implementation. needs-ci PRs that need a full CI run. web-standards Issues and PRs related to Web APIs
10 participants
@KhafraDev @nodejs-github-bot @RedYetiDev @anonrig @jasnell @mcollina @MattiasBuelens @benjamingr @Ethan-Arrowood @atlowChemi