Code Quality: Improved app startup routine 2 - Checkpoint 2 #14045
+132
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5a41c3.
hishitetsu
reviewed
Dec 21, 2023
Comment on lines
40
to
44
| var folder = await StorageService.GetFolderAsync(listedItem.ItemPath); | ||
| await StartMenuService.PinAsync(folder, listedItem.Name); | ||
| IStorable storable = listedItem.IsFolder switch | ||
| { | ||
| true => await StorageService.GetFolderAsync(listedItem.ItemPath), | ||
| _ => await StorageService.GetFileAsync(listedItem.ItemPath) | ||
| }; | ||
| await StartMenuService.PinAsync(storable, listedItem.Name); |
There was a problem hiding this comment.
I think this fix should be separated from the others and merged immediately, because crashes on pinning are one of the most frequent crashes.
Comment on lines
36
to
41
| var folder = await StorageService.GetFolderAsync(listedItem.ItemPath); | ||
| await StartMenuService.UnpinAsync(folder); | ||
| IStorable storable = listedItem.IsFolder switch | ||
| { | ||
| true => await StorageService.GetFolderAsync(listedItem.ItemPath), | ||
| _ => await StorageService.GetFileAsync(listedItem.ItemPath) | ||
| }; | ||
| await StartMenuService.UnpinAsync(storable); |
|
It crashes again when keeping it in background 😭 |
When I tried it, nothing content was displayed in the first place... |
Jay-o-Way
reviewed
Dec 27, 2023
Comment on lines
38
to
+41
| if (value >= 0 && value < MainPageViewModel.AppInstances.Count) | ||
| { | ||
| Frame rootFrame = (Frame)MainWindow.Instance.Content; | ||
| var mainView = (MainPage)rootFrame.Content; | ||
| mainView.ViewModel.SelectedTabItem = MainPageViewModel.AppInstances[value]; | ||
| if (MainWindow.Instance.GetMainPage() is { } mainPage) | ||
| mainPage.ViewModel.SelectedTabItem = MainPageViewModel.AppInstances[value]; |
There was a problem hiding this comment.
Might as well combine the IF statements.
|
I'll work on it more tomorrow 🙂 |
8 tasks
|
Some progress: there's no longer a crash when resuming from background, however the app content stays empty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: DirectoryNotFoundException in PinToStartAction #13947
Validation
How did you test these changes?