Swift: Expand models for UnsafePointer and friends #15052
+238
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the models for the 8 core Swift pointer classes (
UnsafePointerand friends), plusSlice. These models were very fragmented and mostly just consisted of the 'closure methods' we've made an effort on + a few things we happened to use in tests of other functionality. Now they're now more-or-less completely modelled.There are quite a large number of MAD rows in this PR because, as far as I can tell, there's not much class hierarchy between the 8 pointer classes. There are lots of similarities / duplication, but also lots of (possibly justified) minor differences. I've only created a random scatter of test cases, we'll just have to trust that the documentation + my models are accurate ... or alternatively, trust that the impact of any mistakes is likely to be quite low compared to the impact of not having these models at all!