The Wayback Machine - https://web.archive.org/web/20231128091739/https://github.com/laravel/framework/pull/48884
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Set JsonException as previous exception to Illuminate\Queue\InvalidPayloadException #48884

Draft
wants to merge 5 commits into
base: 10.x
Choose a base branch
from
Draft

[10.x] Set JsonException as previous exception to Illuminate\Queue\InvalidPayloadException #48884

wants to merge 5 commits into from

Conversation

crynobone
Copy link
Member

Replace PR #48856
crynobone and others added 2 commits November 2, 2023 07:59
@crynobone
[10.x] Set JsonException as previous exception to
ce7581c 
`Illuminate\Queue\InvalidPayloadException`

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@StyleCIBot
Apply fixes from StyleCI
1108011
@crynobone crynobone marked this pull request as draft November 2, 2023 00:09
@crynobone crynobone mentioned this pull request Nov 2, 2023
Draft
@aimeos
Copy link
Contributor

aimeos commented Nov 2, 2023

For me, it looks too complicated to throw/catch/throw an exception. The intention of the previous PR was only to improve the error message to be more useful in the debug view.
@crynobone crynobone marked this pull request as ready for review November 3, 2023 02:12
@taylorotwell taylorotwell reopened this Nov 3, 2023
@taylorotwell
Copy link
Member

What was wrong with #48856
@taylorotwell taylorotwell marked this pull request as draft November 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants
@crynobone @aimeos @taylorotwell @driesvints @StyleCIBot