Tyriar
Follow
Pinned
6,161 contributions in the last year
Activity overview
Contribution activity
September 2023
Created 234 commits in 4 repositories
Created a pull request in microsoft/vscode that received 4 comments
Fix createTerminal embedder API
Fixes microsoft/vscode-internalbacklog#4557 @osortega could you try this out when it's merged?
+8
−2
•
4
comments
Opened 42 other pull requests in 5 repositories
xtermjs/xterm.js
17
merged
- Don't re-render after parse is the viewport did not change
- Remove noisy trace calls
- Tweak playwright workers
- Fix block cursor rendering in DOM renderer
- Fix possible exception when disposing terminal
- Fix server debugging
- Fix regression in force mouse selection
- Add edge debug target
- Fix webgl/dom inverse MCR edge cases, add regression test
- Fix MCR test on webkit, add pollForApproximate
- Fix viewport error during term dispose
- Avoid block elements in renderer tests
- Add canvas renderer tests
- DOM renderer playwright tests
- Disable image addon publishing
- v5.3.0 and bump all addons
- Upgrade es6 -> es2021
microsoft/vscode
14
merged
1
closed
- Adopt disposableTimeout store arg in terminal
- [email protected]
- Fix onBell listener being registered after term dispose, allow for DisposableStore-managed disposableTimeouts
- Fix protected minification error
- Add placeholder for rename and change color term tab
- Update distro
- [email protected]
- Finalize env.onDidChangeShell
- Finalize terminal/context, terminal/title/context
- [email protected]
- Remove overriding of dispose from terminal
- Fix Throttler dispose warning in unit tests
- Adopt ensureNoDisposablesAreLeakedInTestSuite in terminal
- Add separator to test output
- Return an optional DisposableStore from leak fn
xtermjs/xtermjs.org
6
merged
microsoft/vscode-docs
2
merged
1
open
microsoft/vscode-python
1
merged
Reviewed 94 pull requests in 11 repositories
microsoft/vscode
25 pull requests
- Note when settings ToC gets disposed
- don't reveal active terminal before navigating in accessible terminal view
- Fix onBell listener being registered after term dispose, allow for DisposableStore-managed disposableTimeouts
- pass store to disposableTimeout
- fix: respect values from --disable-features flag
- task terminal status test take 2 adoption of ensure no disposables are leaked
- add disposableTimeout calls to disposable stores
- do not register profile icons
- update distro pointer
- add mic profile icon
- mark CC debug toolbar location as experiemental
- fix terminal status issue
- when instance's target is editor, focus that instead of panel
-
fire
onDidReconnectToTaskswhen there are no task terminals to reconnect to so tasks run onfolderOpen - Dedupe continue-on and local un-submitted comments
- get terminal accessible view/buffer to update dynamically
- quick fix clean up
- Fix terminal context menu not hiding after running action
- Add support to de-emphasize debuggers in run list
- fix: do not set this._sequence to undefined if path title not windows path
- voice - cleanup disposables
- feat: copy command and output in integrated terminal
- fire active, inactive before, after lines are processed for reconnected task terminals
- Fix OverviewRulerDecorationsGroup equality check
- fix #192930
- Some pull request reviews not shown.
xtermjs/xterm.js
12 pull requests
- Add support to ANSI OSC52
- Add column restriction
- Correct graphemes addon readme and typings
- Move WidthCache measure container to helper container
- Add regression test,checking inactive selection.
- Clear repeat overviewRulerWidth option in demo
- using isCursorInitialized for domrenderer
- change repository URL of all addons
- get voiceover to announce terminal output consistently
- Add handling of invisible
- DomRenderer draw selection inactive background correctly when unfocused
- When DomRenderer focus,render the cursor line.
microsoft/language-server-protocol
5 pull requests
microsoft/vscode-python
4 pull requests
xtermjs/xtermjs.org
3 pull requests
microsoft/vscode-flake8
1 pull request
microsoft/vscode-black-formatter
1 pull request
microsoft/vscode-dwarf-debugging
1 pull request
microsoft/vscode-github-triage-actions
1 pull request
jerch/xterm-wasm-parts
1 pull request
microsoft/vscode-pull-request-github
1 pull request
Created an issue in microsoft/vscode that received 11 comments
Top padding is wrong on comment view zone
Notice the hover feedback is cut off vertically and should have additional spacing. Setup: Korean language pack (may impact?) `"window.zoomLevel": 2
11
comments
Opened 85 other issues in 8 repositories
microsoft/vscode
29
open
28
closed
- npm integration info is broken
- Profile icon search should be more fuzzy
- Profile icon should have a focus border when focus is not in text area
- Profile icon picker has a scroll bar when there should be enough room
- taskTerminalStatus.test.ts doesn't use ensureNoDisposablesAreLeakedInTestSuite correctly
- Sticky scroll in output is the wrong color
- Consider adopting automatic management of disposableTimeout's disposable by passing in a store
- Search editor can show invalid values for context lines
- Consider moving DisposableStore back to using an array
- Remove TerminalInstance._isDisposed
- Improve chat view's horizontal code scrolling visual feedback
- Quick chat container can be focused and has focus border cut off
- alt+enter cannot be bound to terminal quick fix
- Terminal tab rename does not work with multi-select
- Terminal tab change color does not work with multi-select
- Terminal tab change icon does not work with multi-select
- Add placeholder to terminal change icon and color
- Tasks should add a new line before the VS Code format message if it's not at the start of a line
- Problem navigation keybindings should be active even when there is no editor open
- I was asked randomly whether i wanted to use Japanese display language?
- Reloading a window switched the locale from Korean to English
- Remove terminalLogService
- Unbounded keybindings are presented in empty workbench hints
- Support menu bar mnemonics with an overlay while alt is held
- Quick pick: Support searching hangul treating last character as partially formed
- Some issues not shown.
xtermjs/xterm.js
7
open
13
closed
- Viewport scroll events may not change ydisp when input is being parsd
- Links get re-evaluated when buffer changes happen outside viewport
- WidthCache is added document.body, it should be a child of .xterm-helpers ideally
- Webgl renderer: Inactive cursor can render in the wrong spot
- Set up publishing for unicode graphemes addon
- Regression in mouse events which breaks tmux
- Remove the canvas renderer addon
- Error in playwright tests: Error [TypeError]: this._renderer.value is undefined
- DOM renderer: Cursor is no longer rendered on top of selection
- Avoid using block element characters in playwright tests
- Error in playwright tests: Error [TypeError]: Cannot read properties of undefined (reading 'dimensions')
- WebKit playwright test failure: minimumContrastRatio - should enforce half the contrast for dim cells
- Introduce DOM renderer (or renderer agnostic) playwright tests
- DOM renderer may clip overline
- DOM renderer does not respect minimum contrast ratio correctly on selected inverse text
- Invisible text is visible in the DOM renderer
- Webgl/canvas inverse resolves minimum contrast color using the default background, not the inverse
- DOM renderer: Selection background is drawn incorrectly when unfocused
- DOM renderer does not re-render cursor on focus
- Switching to dom renderer does not render inverse selection fg correctly
microsoft/vscode-pull-request-github
1
open
1
closed
microsoft/vscode-python
2
open
microsoft/vscode-docs
1
open
xtermjs/xtermjs.org
1
closed
microsoft/vscode-loc
1
closed
oven-sh/bun
1
closed
Answered 2 discussions in 1 repository
xtermjs/xterm.js
xtermjs/xterm.js
-
How to obtain the content of the current line, including terminal characters
This contribution was made on Sep 12
-
Selection Doesn't works on touch device
This contribution was made on Sep 10
57
contributions
in private repositories
Sep 6 – Sep 24