The Wayback Machine - https://web.archive.org/web/20230820211129/https://github.com/microsoft/fluentui/pull/22750
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable yarn frozen lockfile during install #22750

Merged
merged 1 commit into from May 2, 2022
Merged

ci: enable yarn frozen lockfile during install #22750

merged 1 commit into from May 2, 2022

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 2, 2022

Current Behavior

install on CI won't fail if yarn.lock is not up to date

New Behavior

install on CI will fail if yarn.lock is not up to date

Related Issue(s)
@Hotell Hotell requested a review from a team as a code owner May 2, 2022 10:51
@Hotell Hotell enabled auto-merge (squash) May 2, 2022 10:54
@Hotell Hotell added this to In progress in V-Build - @microsoft/fluentui-react-build via automation May 2, 2022
@Hotell Hotell added this to the May Project Cycle Q2 2022 milestone May 2, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a4d91c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 902 915 5000
Button mount 565 566 5000
FluentProvider mount 1814 1850 5000
FluentProviderWithTheme mount 276 286 10
FluentProviderWithTheme virtual-rerender 257 248 10
FluentProviderWithTheme virtual-rerender-with-unmount 317 288 10
MakeStyles mount 1595 1595 50000

@size-auditor
Copy link

size-auditor bot commented May 2, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: df7387d8394994e1802cb1354a327b86a4d41604 (build)
@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 73.754 kB
22.494 kB
react-badge
Badge		 20.965 kB
6.605 kB
react-badge
CounterBadge		 21.918 kB
6.919 kB
react-badge
PresenceBadge		 22.005 kB
6.582 kB
react-combobox
Combobox		 60.564 kB
20.751 kB
react-divider
Divider		 15.455 kB
5.57 kB
react-overflow
hooks only		 10.792 kB
4.125 kB
react-positioning
usePopper		 23.21 kB
8.084 kB
react-radio
Radio		 23.556 kB
7.898 kB
react-radio
RadioGroup		 8.205 kB
3.516 kB
react-spinbutton
SpinButton		 41.955 kB
11.856 kB
react-spinner
Spinner		 17.292 kB
5.865 kB
react-switch
Switch		 24.401 kB
8.024 kB
react-textarea
Textarea		 20.672 kB
7.07 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.347 kB
7.04 kB
react-theme
Teams: Light theme		 19.792 kB
5.694 kB
react-tooltip
Tooltip		 42.907 kB
14.761 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against df7387d8394994e1802cb1354a327b86a4d41604
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 147 136 1.08:1
BoxMinimalPerf.default 313 293 1.07:1
AttachmentMinimalPerf.default 133 128 1.04:1
FlexMinimalPerf.default 259 249 1.04:1
ListNestedPerf.default 478 461 1.04:1
AttachmentSlotsPerf.default 878 850 1.03:1
ChatDuplicateMessagesPerf.default 236 229 1.03:1
ChatWithPopoverPerf.default 315 306 1.03:1
HeaderSlotsPerf.default 700 681 1.03:1
ReactionMinimalPerf.default 343 332 1.03:1
RefMinimalPerf.default 213 206 1.03:1
ListCommonPerf.default 533 525 1.02:1
ListWith60ListItems.default 531 519 1.02:1
ButtonSlotsPerf.default 421 415 1.01:1
CarouselMinimalPerf.default 359 356 1.01:1
DividerMinimalPerf.default 325 321 1.01:1
DropdownManyItemsPerf.default 552 549 1.01:1
DropdownMinimalPerf.default 2519 2503 1.01:1
GridMinimalPerf.default 297 294 1.01:1
InputMinimalPerf.default 1000 986 1.01:1
LayoutMinimalPerf.default 318 316 1.01:1
RosterPerf.default 887 880 1.01:1
RadioGroupMinimalPerf.default 399 395 1.01:1
TextMinimalPerf.default 312 310 1.01:1
CustomToolbarPrototype.default 2221 2209 1.01:1
ButtonOverridesMissPerf.default 1171 1175 1:1
CardMinimalPerf.default 498 497 1:1
CheckboxMinimalPerf.default 1947 1948 1:1
ImageMinimalPerf.default 322 321 1:1
ItemLayoutMinimalPerf.default 998 997 1:1
LabelMinimalPerf.default 341 342 1:1
MenuMinimalPerf.default 747 746 1:1
MenuButtonMinimalPerf.default 1372 1375 1:1
ProviderMergeThemesPerf.default 994 994 1:1
SliderMinimalPerf.default 1324 1322 1:1
SplitButtonMinimalPerf.default 3345 3333 1:1
StatusMinimalPerf.default 615 618 1:1
TableManyItemsPerf.default 1639 1639 1:1
TextAreaMinimalPerf.default 434 433 1:1
TooltipMinimalPerf.default 940 944 1:1
AnimationMinimalPerf.default 486 489 0.99:1
ButtonMinimalPerf.default 134 135 0.99:1
DialogMinimalPerf.default 680 689 0.99:1
EmbedMinimalPerf.default 2959 2994 0.99:1
HeaderMinimalPerf.default 317 321 0.99:1
ListMinimalPerf.default 456 461 0.99:1
PopupMinimalPerf.default 548 556 0.99:1
ProviderMinimalPerf.default 316 318 0.99:1
TableMinimalPerf.default 356 358 0.99:1
ToolbarMinimalPerf.default 822 829 0.99:1
VideoMinimalPerf.default 563 567 0.99:1
AlertMinimalPerf.default 225 230 0.98:1
ChatMinimalPerf.default 643 655 0.98:1
LoaderMinimalPerf.default 524 533 0.98:1
SegmentMinimalPerf.default 300 305 0.98:1
SkeletonMinimalPerf.default 306 311 0.98:1
TreeMinimalPerf.default 704 718 0.98:1
AvatarMinimalPerf.default 165 170 0.97:1
DatepickerMinimalPerf.default 4583 4731 0.97:1
FormMinimalPerf.default 347 356 0.97:1
PortalMinimalPerf.default 142 146 0.97:1
IconMinimalPerf.default 531 546 0.97:1
AccordionMinimalPerf.default 119 129 0.92:1
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 686 770 5000
Breadcrumb mount 2087 2076 1000
Checkbox mount 1207 1143 5000
CheckboxBase mount 964 981 5000
ChoiceGroup mount 3747 3621 5000
ComboBox mount 827 838 1000
CommandBar mount 8356 8489 1000
ContextualMenu mount 9362 9453 1000
DefaultButton mount 920 857 5000
DetailsRow mount 2943 3080 5000
DetailsRowFast mount 2981 2994 5000
DetailsRowNoStyles mount 2825 2844 5000
Dialog mount 1744 1767 1000
DocumentCardTitle mount 148 158 1000
Dropdown mount 2575 2512 5000
FocusTrapZone mount 1431 1428 5000
FocusZone mount 1442 1441 5000
IconButton mount 1433 1413 5000
Label mount 303 273 5000
Layer mount 2263 2393 5000
Link mount 371 373 5000
MenuButton mount 1132 1134 5000
MessageBar mount 1687 1674 5000
Nav mount 2826 2534 1000
OverflowSet mount 804 832 5000
Panel mount 1670 1705 1000
Persona mount 774 755 1000
Pivot mount 1118 1107 1000
PrimaryButton mount 1136 983 5000
Rating mount 6268 6094 5000
SearchBox mount 984 1000 5000
Shimmer mount 1959 1922 5000
Slider mount 1607 1511 5000
SpinButton mount 3882 4112 5000
Spinner mount 329 365 5000
SplitButton mount 2468 2572 5000
Stack mount 448 395 5000
StackWithIntrinsicChildren mount 1733 1870 5000
StackWithTextChildren mount 4100 4181 5000
SwatchColorPicker mount 9235 8942 5000
TagPicker mount 2155 2161 5000
TeachingBubble mount 81428 83384 5000
Text mount 374 324 5000
TextField mount 1078 1081 5000
ThemeProvider mount 904 940 5000
ThemeProvider virtual-rerender 468 487 5000
ThemeProvider virtual-rerender-with-unmount 1449 1460 5000
Toggle mount 598 607 5000
buttonNative mount 88 102 5000

V-Build - @microsoft/fluentui-react-build automation moved this from In progress to Reviewer approved May 2, 2022
@Hotell Hotell merged commit a6dffdb into microsoft:master May 2, 2022
34 checks passed
V-Build - @microsoft/fluentui-react-build automation moved this from Reviewer approved to Done May 2, 2022
@Hotell Hotell deleted the hotell/ci/enable-yarn-frozen branch May 2, 2022 12:57
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
@Hotell @marwan38
ci: enable yarn frozen lockfile during install (microsoft#22750)
c4e5d62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build System
4 participants
@Hotell @fabricteam @ling1726 @GeoffCoxMSFT