The Wayback Machine - https://web.archive.org/web/20210628142820/https://github.com/ionic-team/ionic-framework/pull/22883
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): prevent race conditions when opening overlays #22883

Merged
merged 3 commits into from Feb 23, 2021
Merged

Conversation

@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Feb 5, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22880

What is the new behavior?

  • Check if overlay is opening/dismissing before doing anything

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi force-pushed the vr-overlay branch from 3ede130 to cc5c8c6 Feb 9, 2021
@liamdebeasi liamdebeasi added this to In progress 🤺 in Ionic Core via automation Feb 23, 2021
@liamdebeasi liamdebeasi merged commit 68a9b80 into master Feb 23, 2021
2 checks passed
2 checks passed
@github-actions
triage
Details
@circleci-checks
build Workflow: build
Details
Ionic Core automation moved this from In progress 🤺 to Done 🎉 Feb 23, 2021
@liamdebeasi liamdebeasi deleted the vr-overlay branch Feb 23, 2021
cerkiner added a commit to cerkiner/ionic that referenced this pull request Mar 2, 2021
* master: (284 commits)
  fix(label): only show placeholder with floating label when focused (ionic-team#22958)
  feat(react): add react hooks to control overlay components (ionic-team#22484)
  feat(vue): add composition API ionic lifecycle hooks (ionic-team#22970)
  chore(): run build
  5.5.5
  fix(vue): account for event name changes in vue 3.0.6+
  fix(react, vue): navigating using ion-back-button now selects correct page (ionic-team#22974)
  fix(progress-bar): use correct theme colors in dark mode (ionic-team#22965)
  fix(progress-bar): add width transition (ionic-team#22964)
  fix(vue): prevent race conditions when opening overlays (ionic-team#22883)
  fix(progress-bar): use correct theme colors in dark mode (ionic-team#22957)
  feat(searchbar): add showClearIcon property (ionic-team#22759)
  test(): update theming test with latest dark mode values (ionic-team#22956)
  chore(): update package-lock to account for npm 7.5.3 bug fix (ionic-team#22963)
  fix(header): collapsed toolbar is no longer incorrectly shown when using ion-refresher (ionic-team#22937)
  fix(react): onIonTabsWillChange and onIonTabsDidChange event handlers are now properly bound to IonTabs (ionic-team#22233)
  fix(refresher): add correct dark mode styles (ionic-team#22639)
  feat(custom-elements): add experimental custom elements build  (ionic-team#22863)
  fix(a11y): improve support for ids with special characters when getting label element (ionic-team#22680)
  chore(): update code of conduct (ionic-team#22619)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant