The Wayback Machine - https://web.archive.org/web/20230609093031/https://github.com/ionic-team/ionic-framework/pull/27611
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): onDoubleClick fires on components #27611

Merged
merged 4 commits into from Jun 8, 2023
Merged

fix(react): onDoubleClick fires on components #27611

merged 4 commits into from Jun 8, 2023

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jun 6, 2023

Issue number: Resolves #21320


What is the current behavior?

onDoubleClick bindings on Ionic components do not fire when the element is double clicked.

What is the new behavior?

  • onDoubleClick fires on Ionic components
  • Fixed the unit testing set-up for the react test apps

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codeflowapp
Copy link

codeflowapp bot commented Jun 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added package: core @ionic/core package package: react @ionic/react package labels Jun 6, 2023
Copy link
Contributor

@amandaejohnston amandaejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@sean-perkins sean-perkins added this pull request to the merge queue Jun 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 8, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Jun 8, 2023
@liamdebeasi liamdebeasi removed this pull request from the merge queue Jun 8, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit 3e191df Jun 8, 2023
45 checks passed
@liamdebeasi liamdebeasi deleted the FW-4124 branch June 8, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: react @ionic/react package
3 participants