There are no hard and fast rules—Only tradeoffs.
Block or Report
Block or report inancgumus
Report abuse
Contact GitHub support about this user’s behavior. Learn more about reporting abuse.
Report abusePinned
-
-
prettyslice Public
Pretty prints slices to any io.Writer: I created this package to teach slices in my Go course.
1,029 contributions in the last year
Less
More
Activity overview
Contributed to
grafana/xk6-browser,
inancgumus/effective-go,
grafana/k6-docs
and 8 other
repositories
Contribution activity
March 2023
Created 158 commits in 2 repositories
Created a pull request in grafana/xk6-browser that received 13 comments
Refactor logger.New to accept FieldLogger
While doing this I've also refactored the code a little bit. Let me know if you think the otherwise. Closes: #823
+11
−11
•
13
comments
Opened 7 other pull requests in 1 repository
grafana/xk6-browser
7
merged
- Fix killing a browser process on panic if one of them is missing
- Update to k6-core master and fix BPool
- Fix Edge-case: Mapping fails if the extension code returns nil values #804
- Upgrade to k6-core v0.43.1
- Add error handling to wildcard selectors
- Add browser close friendly err (#687)
- Add assert log contains and log dump helpers
Reviewed 8 pull requests in 1 repository
grafana/xk6-browser
8 pull requests
- Fix close page so that it closes the current page and not the whole browser context
- Fix Edge-case: Mapping fails if the extension code returns nil values #804
- Refactor logger.New to accept FieldLogger
- Add error handling to wildcard selectors
- Rename ErrInternal to ErrFatal and use abort
- Fix incorrect keyboard key code on down and up
- Add browser close friendly err (#687)
-
Implement
BrowserType.connect
Opened 6 issues in 1 repository
grafana/xk6-browser
2
closed
4
open
-
Allow making a logger from
FieldLoggerinstead of concrete*Logrus - Use k6 LookupEnv instead of os.GetEnv and os.LookupEnv
- Abort the iteration on panic even if caught
- Log instead of panicking when closing the browser
- Update JS examples (add catch)
- Edge-case: Mapping fails if the extension code returns nil values






