Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
[browser] prevent <DebuggerSupport> from disabling interp optimizations #85792
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAnd timeouts while running those unit tests.
|
@pavelsavara and @BrzVlad found that some tests like System.Collections.Immutable.Tests run slower because the runtime has debugging enabled which causes the interpreter to disable optimizations. Reason: - Some tests depend on debugger attributes, and thus set `$(DebuggerSupport)=true` to preserve them while linking. - Which sets `$(WasmDebugLevel)=-1`. But setting `$(WasmDebugLevel)<0` enables debugging support in the runtime. - So, set this to `<0` only when building with `Configuration=Debug` .
radical
force-pushed
the
browser_debug_level
branch
from
9ddd6de
to
2690c47
Compare
|
/azp runtime-wasm-libtests |
|
Command 'runtime-wasm-libtests' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
And timeouts while running those unit tests.
@pavelsavara and @BrzVlad found that some tests like
System.Collections.Immutable.Tests run slower because the runtime has
debugging enabled which causes the interpreter to disable optimizations.
Reason:
Some tests depend on debugger attributes, and thus set
$(DebuggerSupport)=trueto preserve them while linking.Which sets
$(WasmDebugLevel)=-1. But setting$(WasmDebugLevel)<0enables debugging support in the runtime.
So, set this to
<0only when building withConfiguration=Debug.The motivation for
DebuggerSupportis to keepDebuggerDisplayAttributenot trimmed.See https://github.com/dotnet/runtime/pull/48226/files#r617735629