[ISSUE #5484] Replace logging module with the shaded logback #5540
Conversation
aaron-ai
force-pushed
the
remove_logging_module
branch
2 times, most recently
from
2b45f3e
to
5f2c8d7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5540 +/- ##
=============================================
- Coverage 42.72% 42.52% -0.20%
+ Complexity 8032 7952 -80
=============================================
Files 1031 1022 -9
Lines 72741 71249 -1492
Branches 9613 9398 -215
=============================================
- Hits 31079 30301 -778
+ Misses 37718 37120 -598
+ Partials 3944 3828 -116
|
aaron-ai
force-pushed
the
remove_logging_module
branch
from
5f2c8d7
to
aac7e19
Compare
aaron-ai
requested review from
zhouxinyu,
drpmma,
fuyou001,
lizhanhui and
lollipopjin
| <dependency> | ||
| <groupId>io.github.aliyun-mq</groupId> | ||
| <artifactId>rocketmq-slf4j-api</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.github.aliyun-mq</groupId> | ||
| <artifactId>rocketmq-logback-classic</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
IMO, It would be better to put it in a more neutral repo.
There was a problem hiding this comment.
@RongtongJin Actually a more neutral repo(e.g. some other repos which belong to apache rocketmq) is considered, but we want to avoid the redundant polling procedure at present, because we'd better to keep up to date with the original version, current polling procedure is uncesscary.
On the other hand, I think current group id is ok because the License is more important, or we could refer to the dependency of fastjson.
fixes #5484