The Wayback Machine - https://web.archive.org/web/20230405131520/https://github.com/encode/httpx/pull/2648
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff instead of flake8, autoflake and isort #2648

Merged
merged 4 commits into from Apr 5, 2023
Merged

Use ruff instead of flake8, autoflake and isort #2648

merged 4 commits into from Apr 5, 2023
+22 −30

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Apr 4, 2023 •
edited

Ref.: #2607
@Kludex Kludex requested a review from tomchristie April 4, 2023 10:30
tomchristie
tomchristie reviewed Apr 5, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed Apr 5, 2023
View reviewed changes
tests/client/test_async_client.py
@@ -84,7 +84,7 @@ async def test_access_content_stream_response(server):

assert response.status_code == 200
with pytest.raises(httpx.ResponseNotRead):
response.content
response.content # noqa: B018
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I track down what a B018 is?
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on the rules page: https://beta.ruff.rs/docs/rules/#flake8-bugbear-b

Should I add a comment here or ignore it globally?
Kludex
Kludex commented Apr 5, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
tests/client/test_async_client.py
@@ -84,7 +84,7 @@ async def test_access_content_stream_response(server):

assert response.status_code == 200
with pytest.raises(httpx.ResponseNotRead):
response.content
response.content # noqa: B018
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on the rules page: https://beta.ruff.rs/docs/rules/#flake8-bugbear-b

Should I add a comment here or ignore it globally?
@Kludex Kludex requested a review from tomchristie April 5, 2023 09:35
@Kludex Kludex merged commit daec2bd into master Apr 5, 2023
5 checks passed
@Kludex Kludex deleted the refactor/use-ruff branch April 5, 2023 10:37
@Kludex Kludex mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Kludex @tomchristie