The Wayback Machine - https://web.archive.org/web/20230301043427/https://github.com/facebook/react-native/pull/36197
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BUCK file for WebPerformance (use TurboModule plugins) #36197

Closed
wants to merge 1 commit into from
Closed

Refactor BUCK file for WebPerformance (use TurboModule plugins) #36197

wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Feb 17, 2023

Summary:
[Changelog][Internal]

This turns NativePerformance* module dependencies into "TurboModule plugins", which allows for more streamlined client integration (as it makes them register automatically once the dependency is there).

Differential Revision: D43353204
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Feb 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43353204
@github-actions
Copy link

github-actions bot commented Feb 17, 2023 •
edited

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 5f1e6f7

@analysis-bot
Copy link

analysis-bot commented Feb 17, 2023 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,452,048 +0
android hermes armeabi-v7a 7,775,427 +0
android hermes x86 8,927,648 +0
android hermes x86_64 8,785,265 +0
android jsc arm64-v8a 6,668,649 +0
android jsc armeabi-v7a 7,462,614 +0
android jsc x86 9,192,774 +0
android jsc x86_64 6,893,775 +0

Base commit: ed8a3e0
Branch: main
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43353204
rshest added a commit to rshest/react-native that referenced this pull request Feb 17, 2023
@rshest @facebook-github-bot
Refactor BUCK file for WebPerformance (use TurboModule plugins) (face…
09c9f35 
…book#36197)

Summary:
Pull Request resolved: facebook#36197

[Changelog][Internal]

This turns NativePerformance* module dependencies into "TurboModule plugins", which allows for more streamlined client integration (as it makes them register automatically once the dependency is there).

Reviewed By: rubennorte

Differential Revision: D43353204

fbshipit-source-id: 80bfc052d47d3fa24af99ce92b4f3d7e37c4ed98
@rshest @facebook-github-bot
Refactor BUCK file for WebPerformance (use TurboModule plugins) (face…
5f1e6f7 
…book#36197)

Summary:
Pull Request resolved: facebook#36197

[Changelog][Internal]

This turns NativePerformance* module dependencies into "TurboModule plugins", which allows for more streamlined client integration (as it makes them register automatically once the dependency is there).

Reviewed By: rubennorte

Differential Revision: D43353204

fbshipit-source-id: f6cbd7a25c8aaed5a74b78690f47d9fc83416216
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43353204
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1629b9f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
3 participants
@rshest @facebook-github-bot @analysis-bot