The Wayback Machine - https://web.archive.org/web/20230305151524/https://github.com/apache/kafka/pull/6477
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Use https instead of http in links #6477

Merged
merged 3 commits into from Apr 22, 2019
Merged

Conversation

ijuma
Copy link
Contributor

@ijuma ijuma commented Mar 20, 2019

Verified that the https links work.

I didn't update the license header in this PR since that touches
so many files. Will file a separate one for that.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@ijuma ijuma force-pushed the use-https-in-links branch 2 times, most recently from f097bee to 46075ab Compare March 20, 2019 12:38
@rajinisivaram
Copy link
Contributor

@ijuma The builds seem to have failed.

Verified that the links work.

I didn't update the license header in this PR since that touches
so many files. Will file a separate one for that.
Copy link
Contributor

@omkreddy omkreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma Thanks for the PR. LGTM. left minor comment. also there is a rat check failure.

doap_Kafka.rdf Outdated
<programming-language>Scala</programming-language>
<category rdf:resource="http://projects.apache.org/category/big-data" />
<category rdf:resource="https://projects.apache.org/category/big-data" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like current url in not working. New url: https://projects.apache.org/projects.html?category#big-data

@ijuma ijuma merged commit 7d9e93a into apache:trunk Apr 22, 2019
@ijuma ijuma deleted the use-https-in-links branch April 22, 2019 18:58
@ijuma
Copy link
Contributor Author

ijuma commented Apr 22, 2019

No code changes, so test failure was unrelated (one of the builds passed too).

Pengxiaolong pushed a commit to Pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Verified that the https links work.

I didn't update the license header in this PR since that touches
so many files. Will file a separate one for that.

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants