The Wayback Machine - https://web.archive.org/web/20230205045137/https://github.com/CodeEditApp/CodeEdit/pull/1039
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved welcomewindow #1039

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Wouter01
Copy link
Collaborator

@Wouter01 Wouter01 commented Feb 3, 2023

Description

This PR simplifies the code for the Recent Projects List, adds multiselection behavior to that list, and unifies it with the built-in macOS recent files list.

This solves the problem where the recent files list in the welcome window would differ from the one provided by the system in File -> Open, and CodeEdit Icon -> Right click. The welcome window now gets updated instantly, also when a new project has been openend by e.g. dragging it to the CodeEdit icon in the dock.

Certain list features, like selection multiple items, don't have any lag anymore.

Note: this PR has the minimum target set to 13.0. It should not be merged until the main repo has moved to 13.0

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
@Wouter01 Wouter01 added the enhancement New feature or request label Feb 3, 2023
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant