The Wayback Machine - https://web.archive.org/web/20230218070855/https://github.com/huggingface/transformers/pull/21370
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLAP] Add CLAP to the library #21370

Merged
merged 227 commits into from Feb 16, 2023
Merged

[CLAP] Add CLAP to the library #21370

merged 227 commits into from Feb 16, 2023
+5,104 −15

Conversation

ArthurZucker
Copy link
Contributor

What does this PR do?

Adds CLAP to the HF library cc @younesbelkada
ArthurZucker and others added 30 commits January 30, 2023 14:14
@ArthurZucker
add model like clip
c6b06b5
@ArthurZucker
update
7547c82
@younesbelkada
text model ok
23c56ac
@younesbelkada
Merge branch 'add-clap-model' of https://github.com/ArthurZucker/tran…
405e653 
…sformers into HEAD
@younesbelkada
clap text works
1771782
@younesbelkada
some refactor
9b276aa 
- `CLAPVision` to `CLAPAudio`
- refactor kwargs of audio modules
@younesbelkada
more refactor
45c36ba
@younesbelkada
more refactor
abee382
@younesbelkada
more refactor
a7219ec
@younesbelkada
correct fusion
c553315
@younesbelkada
more refactor
4360623
@younesbelkada
new modules
e3aff6f
@ArthurZucker
add basic processor
00eb73b
@ArthurZucker
fixup
45e7ce9
@ArthurZucker
remove whisper copioed from
b5c483f
@ArthurZucker
Merge branch 'add-clap-model' of https://github.com/ArthurZucker/tran…
4084369 
…sformers into add-clap-model
@younesbelkada
audio logits match
fc0d323
@ArthurZucker
add doc
8a27723
@ArthurZucker
correct filters mel and add maxlength
27f133f
@ArthurZucker
style
5ddc2f3
@ArthurZucker
Merge branch 'add-clap-model' of https://github.com/ArthurZucker/tran…
fbb6124 
…sformers into add-clap-model
@younesbelkada
few fixes
815c5ce
@ArthurZucker
forward passes
95c400b
@ArthurZucker
fixup
a41ff1a
@ArthurZucker
Merge branch 'add-clap-model' of https://github.com/ArthurZucker/tran…
38f7fe8 
…sformers into add-clap-model
@ArthurZucker
fixup
275633c
@younesbelkada
some clean up
1b3a820
@ArthurZucker
remove mels form the dictionnary
8fed2d0
@ArthurZucker
Merge branch 'add-clap-model' of https://github.com/ArthurZucker/tran…
2684c70 
…sformers into add-clap-model
@ArthurZucker
pad after the repeat
6b9051c
@ArthurZucker ArthurZucker mentioned this pull request Feb 14, 2023
Open
sanchit-gandhi
sanchit-gandhi approved these changes Feb 15, 2023
View changes
Copy link
Contributor

@sanchit-gandhi sanchit-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice PR! Thanks @ArthurZucker and @younesbelkada for your work here!
src/transformers/models/clap/configuration_clap.py Outdated Show resolved Hide resolved
src/transformers/models/clap/configuration_clap.py Outdated Show resolved Hide resolved
src/transformers/models/clap/configuration_clap.py Show resolved Hide resolved
src/transformers/audio_utils.py Show resolved Hide resolved
src/transformers/models/clap/modeling_clap.py Outdated Show resolved Hide resolved
src/transformers/models/clap/modeling_clap.py Show resolved Hide resolved
src/transformers/models/clap/modeling_clap.py Show resolved Hide resolved
@ArthurZucker
Copy link
Contributor Author

Found a few discrepancies with the various variables in the config that are not used. Will finish asap should makes things clearer.
@ArthurZucker
Copy link
Contributor Author

Ok I broke the history
@ArthurZucker ArthurZucker merged commit c236a62 into huggingface:main Feb 16, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New model
6 participants
@ArthurZucker @HuggingFaceDocBuilderDev @younesbelkada @Narsil @sgugger @sanchit-gandhi