http: use v8::Array::New() with a prebuilt vector #46447
+22
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using v8::Array::Set() which results in JS execution and is thus slow. Prebuild the vector in C++ land and build the JS array directly with that vector whereever possible.
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
approved these changes
Jan 31, 2023
ronag
reviewed
Jan 31, 2023
| ConnectionsList* list; | ||
|
|
||
| ASSIGN_OR_RETURN_UNWRAP(&list, args.Holder()); | ||
|
|
||
| uint32_t i = 0; | ||
| std::vector<Local<Value>> result; |
There was a problem hiding this comment.
Suggested change
| std::vector<Local<Value>> result; | |
| std::vector<Local<Value>> result; | |
| result.reserve(list->all_connections_.size()); |
ronag
reviewed
Jan 31, 2023
| ConnectionsList* list; | ||
|
|
||
| ASSIGN_OR_RETURN_UNWRAP(&list, args.Holder()); | ||
|
|
||
| uint32_t i = 0; | ||
| std::vector<Local<Value>> result; |
There was a problem hiding this comment.
Suggested change
| std::vector<Local<Value>> result; | |
| std::vector<Local<Value>> result; | |
| result.reserve(list->all_connections_.size()); |
ronag
reviewed
Jan 31, 2023
| ConnectionsList* list; | ||
|
|
||
| ASSIGN_OR_RETURN_UNWRAP(&list, args.Holder()); | ||
|
|
||
| uint32_t i = 0; | ||
| std::vector<Local<Value>> result; |
There was a problem hiding this comment.
Suggested change
| std::vector<Local<Value>> result; | |
| std::vector<Local<Value>> result; | |
| result.reserve(list->all_connections_.size()); |
ronag
reviewed
Jan 31, 2023
| auto iter = list->active_connections_.begin(); | ||
| auto end = list->active_connections_.end(); | ||
|
|
||
| std::vector<Local<Value>> result; |
There was a problem hiding this comment.
Suggested change
| std::vector<Local<Value>> result; | |
| std::vector<Local<Value>> result; | |
| result.reserve(list->all_connections_.size()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Avoid using v8::Array::Set() which results in JS execution and is thus slow. Prebuild the vector in C++ land and build the JS array directly with that vector whereever possible.