aduh95
Follow
Pinned
3,237 contributions in the last year
We're celebrating 100 million developers!
Activity overview
Contribution activity
January 2023
Created 86 commits in 6 repositories
Created a pull request in nodejs/node that received 18 comments
esm: mark importAssertions as required
We already always specify a value, and failing to do so would likely be a bug.
+2
−6
•
18
comments
Opened 30 other pull requests in 3 repositories
nodejs/node
9
open
9
merged
-
benchmark: add trailing commas in
benchmark/net -
benchmark: add trailing commas in
benchmark/util -
benchmark: add trailing commas in
benchmark/fs -
benchmark: add trailing commas in
benchmark/async_hooks -
test: add trailing commas in
test/known_issues -
test: add trailing commas in
test/internet -
test: add trailing commas in
test/js-native-api -
test: add trailing commas in
test/node-api -
test: add trailing commas in
test/message -
test: add trailing commas in
test/pseudo-tty - benchmark: add trailing commas
- tools: require more trailing commas
- readline: fix detection of carriage return
- esm: skip file: URL conversion to path when possible
-
doc: remove outdated sections from
maintaining-v8 - module: fix unintended mutation
-
lib: make
Errorobjects instantiation less vulnerable to prototype pollution - test,esm: validate more edge cases for dynamic imports
transloadit/uppy
3
open
3
merged
Reviewed 93 pull requests in 7 repositories
nodejs/node
25 pull requests
- doc: include webstreams in finished() and Duplex.from() parameters
- test_runner: top-level diagnostics not ommited when running with --test
-
doc: correct the
sedcommand for macOS in release process docs - stream: dont access Object.prototype.type during TransformStream init
- meta: move one or more collaborators to emeritus
-
doc: pass string to
textEncoder.encodeas input - stream: validate writable defaultEncoding
- deps: update acorn to 8.8.2
- lib: remove unnecessary ObjectGetValueSafe
- http: throw error if options of http.Server is array
- tools,doc: fix commit message using test instead of deps
- stream: add abort signal for ReadableStream and WritableStream
- url: implement URLSearchParams size getter
- tools: update lint-md-dependencies to @rollup/plugin-commonjs@24.0.1 rollup@3.10.1
- meta: update AUTHORS
- test: add failing test for #45992
- tools: use actions pinned by commit hash on coverage-linux.yml
- url: refactor to use more primordials
-
doc: update output of example in
events.getEventListeners - doc: make some parameters optional in webstreams
- tools: update eslint to 8.32.0
- test: refactor to avoid mutation of global by a loader
-
readline: refactor to use
validateNumber -
test: reduce
fs-write-optional-paramsflakiness -
events: refactor to use
validateNumber - Some pull request reviews not shown.
transloadit/uppy.io
8 pull requests
transloadit/uppy
5 pull requests
- minor enhancements and typo fixes for the hungarian translation
- Dashboard: disallow clicking on buttons and links in Dashboard disabled mode
- UI: Use form attribite with a form in doc root to prevent outer form submit
- @uppy/utils: better fallbacks for the drag & drop API
- Use load balancer for companion in e2e tests
nodejs/corepack
4 pull requests
nodejs/cjs-module-lexer
1 pull request
tus/tus-node-server
1 pull request
nodejs/nodejs.org
1 pull request
Created an issue in nodejs/node that received 3 comments
Nominating @deokjinkim as a collaborator
I would like to nominate Deokjin Kim (@deokjinkim) as a collaborator. They have been quite active recently in various areas of the codebase. Here i…
3
comments
Answered 1 discussion in 1 repository
nodejs/node
nodejs/node
-
Challenges migrating from `--experimental-specifier-resolution=node` to custom loader `--loader`
This contribution was made on Jan 23